Skip to content

Update path to regexp#218

Merged
frenzzy merged 3 commits intokriasoft:mainfrom
joehenry087:update-path-to-regexp
May 5, 2025
Merged

Update path to regexp#218
frenzzy merged 3 commits intokriasoft:mainfrom
joehenry087:update-path-to-regexp

Conversation

@joehenry087
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@joehenry087
Copy link
Contributor Author

joehenry087 commented May 3, 2025

Upon using this in my project there appears to be an issue with the built dist:

"regeneratorruntime is not defined"

From what I can tell this most likely is triggered from path-to-regexp, maybe using some async code or other in the updated version, since nothing else changed of note in the code with this PR.
https://stackoverflow.com/questions/61755999/uncaught-referenceerror-regeneratorruntime-is-not-defined-in-react

I'm totally unfamiliar with babel so this is not so easy for me to debug.

@frenzzy frenzzy added this to the 10.0.0 milestone May 5, 2025
@frenzzy frenzzy merged commit c8dd715 into kriasoft:main May 5, 2025
0 of 2 checks passed
@frenzzy
Copy link
Member

frenzzy commented May 5, 2025

Thank you for your contribution! It has been released under v10.0.0

@joehenry087
Copy link
Contributor Author

Thank you for your contribution! It has been released under v10.0.0

Oh no! Please see my above comment about the build dist not working.

@frenzzy
Copy link
Member

frenzzy commented May 5, 2025

Yes, I saw it. It was fixed.

@joehenry087
Copy link
Contributor Author

Awesome, thanks for the quick release! This is a great package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants