exclude option for kpt fn eval and kpt fn render
#2957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha41575
force-pushed
the
kpt-fn-exclude
branch
6 times, most recently
from
2b6502d to
c10c426
Compare
natasha41575
changed the title
exclude option for kpt fn eval and kpt fn render
natasha41575
force-pushed
the
kpt-fn-exclude
branch
2 times, most recently
from
7875eea to
67eef17
Compare
natasha41575
force-pushed
the
kpt-fn-exclude
branch
from
cd9ccc7 to
561b5ca
Compare
Contributor
Author
natasha41575
commented
Apr 8, 2022
droot
reviewed
Apr 8, 2022
Contributor
droot
left a comment
droot
left a comment
There was a problem hiding this comment.
Looks pretty neat. I have very minor comments.
droot
approved these changes
Apr 8, 2022
natasha41575
force-pushed
the
kpt-fn-exclude
branch
from
ca0c964 to
20ee1c1
Compare
natasha41575
force-pushed
the
kpt-fn-exclude
branch
from
20ee1c1 to
c61a57e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit: add
excludefunctionality as described in #2930Second commit: add label and annotation selection to selectors/exclusions
Third commit: e2e tests
Design proposal is here: #2971. This PR should not be merged until the design proposal is in.
TODO: Docs