Increased the set count from 8 to 12 so that each key can be mapped chromatically to a unique set element#130
Closed
PrimateCoder wants to merge 1 commit intokosua20:masterfrom
Closed
Increased the set count from 8 to 12 so that each key can be mapped chromatically to a unique set element#130PrimateCoder wants to merge 1 commit intokosua20:masterfrom
PrimateCoder wants to merge 1 commit intokosua20:masterfrom
Conversation
…hromatically to a unique set element
Closed
Author
|
The proof is in the pudding! I needed this change in order to make this video 🙂: |
kosua20
added a commit
that referenced
this pull request
Jul 31, 2023
Owner
|
Thank you for this pull request! This makes sense, I've merged the PR and adjusted a few things: I've added a new Set definition mode (Chromatic) instead of replacing the old mode, to preserve backward compatibility. |
Owner
|
This is now availble in the latest 7.1 release ! Thank you once again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also makes it more practical to use the same color for all effects when assigning color per key.
Existing key color mappings will need a one time update, but I believe the new chromatic mapping is more logical.