Skip to content

Move header file to include then pass it to user #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move header file to include then pass it to user #85

wants to merge 1 commit into from

Conversation

@GyouzaRu
Copy link

@GyouzaRu GyouzaRu commented Feb 25, 2025

Move the header file to the include folder and modify CMakeLists.txt to pass the header file directory to the upper level, which helps with LSP parsing.

chmorgan
chmorgan requested changes Jul 6, 2025
View reviewed changes
Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GyouzaRu can you rebase (minimea.h has changed since you moved yours) and force push? Also, is this so you can deploy minmea as a library?

@chmorgan chmorgan self-assigned this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chmorgan chmorgan chmorgan requested changes

Assignees

@chmorgan chmorgan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GyouzaRu @chmorgan