fix overflow in minmea_scan #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. looks like an easy fix. Not sure if UART noise could end up triggering this or not, but stability is important. @kosma, can this be merged? |
chmorgan
requested changes
Jul 6, 2025
Collaborator
There was a problem hiding this comment.
@matthieu-c-tagheuer @KJ7LNW it would be easier to see the root cause with a new test that causes the problem but it works because minimea is doing YYY to avoid doing bad things. I can see the check but it's unclear why scale shouldn't be larger than max 32 int / 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #56