Skip to content

Conversation

@gustaphe
Copy link
Collaborator

I've wanted to do this for a while, and it recently became much easier. Low priority, but maybe at least worth keeping in mind if we ever need to change either extension.

If this breaks something, that something was not in the tests.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.26 ⚠️

Comparison is base (1dcae2c) 82.38% compared to head (78290b1) 82.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   82.38%   82.12%   -0.26%     
==========================================
  Files          21       21              
  Lines         829      817      -12     
==========================================
- Hits          683      671      -12     
  Misses        146      146              
Impacted Files Coverage Δ
ext/SymEngineExt.jl 50.00% <50.00%> (-30.00%) ⬇️
ext/DataFramesExt.jl 83.33% <83.33%> (-10.00%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gustaphe gustaphe merged commit ed05440 into korsbo:master Jul 2, 2024
@gustaphe gustaphe deleted the extensionrecipes branch July 2, 2024 19:16
@rodrigomha
Copy link

@gustaphe A quick question here. What is now the intended form to use create a markdown table from a Dataframe now that mdtable(DataFrame) is not supported directly? This broke some of my documentation and required to fix Latexify in 0.16.3 for now.

Thanks

@gustaphe
Copy link
Collaborator Author

gustaphe commented Jul 8, 2024

That is unfortunate, we should have had a test for that.
I'm not currently at my computer, but latexify(df) or latexify(df; env=:mdtable) should do the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants