More robust latexification of specific functions #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustaphe
commented
Mar 16, 2023
Collaborator
Author
There was a problem hiding this comment.
Git knows this file was just renamed. Don't know why Github doesn't.
| _latexraw(i::SubString{LaTeXStrings.LaTeXString}; kwargs...) = i | ||
| _latexraw(i::Rational; kwargs...) = i.den == 1 ? latexraw(i.num; kwargs...) : latexraw(:($(i.num)/$(i.den)); kwargs...) | ||
| _latexraw(i::QuoteNode; kwargs...) = _latexraw(i.value) | ||
| _latexraw(i::QuoteNode; kwargs...) = _latexraw(i.value; kwargs...) |
Collaborator
Author
There was a problem hiding this comment.
I think this was a typo.
hyrodium
reviewed
Mar 30, 2023
Contributor
|
The CI failure on Windows seems not related to this PR. |
Co-authored-by: Yuto Horikawa <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 72.23% 72.38% +0.14%
==========================================
Files 23 23
Lines 940 945 +5
==========================================
+ Hits 679 684 +5
Misses 261 261
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #251 .
We were in a strange state for (for lack of a better word) "named" functions like
sin. This way should be more robust.Before
After