Skip to content

🐛 Update Cloud Foundry discovery filter form #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

🐛 Update Cloud Foundry discovery filter form #2727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dffc7a
:bug: Update Cloud Foundry discovery filter form
sjd78 Nov 11, 2025
6d9b977
reduce diffs on schema change
sjd78 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions client/src/app/components/discover-import-wizard/filter-input-cloudfoundry.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,17 @@ export const FilterInputCloudFoundry: React.FC<
FilterInputCloudFoundryProps
> = ({ id, values, onDocumentChanged }) => {
const validationSchema = yup.object().shape({
organizations: yup.array().of(
yup.object().shape({
value: yup
.string()
.min(1, "Organization name must be at least 1 character")
.trim(),
})
),
organizations: yup
.array()
.min(1, "At least one organization is required")
.of(
yup.object().shape({
value: yup
.string()
.min(1, "Organization name must be at least 1 character")
.trim(),
})
),
spaces: yup.array().of(
yup.object().shape({
value: yup.string().min(1, "Space must be at least 1 character").trim(),
Expand Down Expand Up @@ -146,8 +149,8 @@ export const FilterInputCloudFoundry: React.FC<
fieldName="organizations"
addLabel="Add an organization"
removeLabel="Remove this organization"
emptyMessage="No organizations specified"
isRequired={false}
emptyMessage="No organizations specified, at least one is required"
isRequired
/>
</StackItem>

Expand All @@ -160,7 +163,6 @@ export const FilterInputCloudFoundry: React.FC<
addLabel="Add a space"
removeLabel="Remove this space"
emptyMessage="No spaces specified"
isRequired={false}
/>
</StackItem>

Expand All @@ -173,7 +175,6 @@ export const FilterInputCloudFoundry: React.FC<
addLabel="Add a name"
removeLabel="Remove this name"
emptyMessage="No application names specified"
isRequired={false}
/>
</StackItem>
</Stack>
Expand Down
1 change: 1 addition & 0 deletions client/src/app/components/discover-import-wizard/validate-cloudfoundry-schema.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const SUPPORTED_SCHEMA: JsonSchemaObject = {
type: "string",
},
type: "array",
minItems: 1,
},
spaces: {
description: "Space names.",
Expand Down
Loading