🐛 Refactor generate-assets-wizard useWizardReducer to use useImmerReducer (#2658)
#2662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Reducer` (#2658) Following the pattern in discover-import-wizard from PR #2646, update generate-assets-wizard `useWizardReducer` to use immer and `useImmerReducer` for handling the initial state and all reducer actions. This helps keep the initial state clean and resettable, and helps keep the reducer logic simple and focused. No visible changes. ## Summary by CodeRabbit - **Refactor** - Reworked wizard state management to use an immutable-draft approach for more consistent initialization, stable setter references, and reliable reset behavior. - **Bug Fixes** - Fixed readiness computation so Continue/Next reflects profile, parameters, filters, and advanced options immediately and consistently. --------- Signed-off-by: Scott J Dickerson <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
konveyor-ci-bot
bot
requested review from
ibolton336,
rszwajko and
sjd78
as code owners
sjd78
approved these changes
Oct 9, 2025
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
This was referenced Nov 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the pattern in discover-import-wizard from PR #2646, update
generate-assets-wizard
useWizardReducerto use immer anduseImmerReducerfor handling the initial state and all reduceractions. This helps keep the initial state clean and resettable, and
helps keep the reducer logic simple and focused.
No visible changes.
Summary by CodeRabbit
Refactor
Reworked wizard state management to use an immutable-draft approach
for more consistent initialization, stable setter references, and
reliable reset behavior.
Bug Fixes
Fixed readiness computation so Continue/Next reflects profile,
parameters, filters, and advanced options immediately and consistently.
Signed-off-by: Scott J Dickerson [email protected]
Signed-off-by: Cherry Picker [email protected]