-
Notifications
You must be signed in to change notification settings - Fork 51
🐛 In the task drawer, show task kind instead of addon #2590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maayan Hadasi <[email protected]>
WalkthroughReplaced usage of task.addon with task.kind when constructing TaskItem titles in TaskManagerDrawer. Expanded titles now include id and kind. Collapsed titles now include id and kind while retaining appName and priority. No other logic, rendering, or API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
client/src/app/components/task-manager/TaskManagerDrawer.tsx (1)
154-158: Harden title formatting: avoid “undefined” and add a safe fallback to addon.If applicationName is absent (e.g., platform tasks), the collapsed title will render “- undefined - …”. Also, in case kind is missing for any legacy tasks, falling back to addon keeps things readable.
Apply:
- const title = expanded - ? `${task.id} (${task.kind})` - : `${task.id} (${task.kind}) - ${task.applicationName} - ${ - task.priority ?? 0 - }`; + const displayKind = task.kind || task.addon; + const subject = task.applicationName ?? task.platformName; + const title = expanded + ? `${task.id} (${displayKind})` + : `${task.id} (${displayKind})${subject ? ` - ${subject}` : ""} - ${task.priority ?? 0}`;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
client/src/app/components/task-manager/TaskManagerDrawer.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: unit-test
- GitHub Check: build-and-upload-for-global-ci
🔇 Additional comments (1)
client/src/app/components/task-manager/TaskManagerDrawer.tsx (1)
154-158: Good fix: using task.kind in the title meets the PR objective.This change correctly surfaces the task kind (e.g., “tech-discovery”) and should resolve MTA-6046 in the apps drawer.
sjd78
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves: https://issues.redhat.com/browse/MTA-6046 Fixes: konveyor#2589 UI tests PR: 1663 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * Updated Task Manager task titles: both expanded and collapsed states now display task ID and Kind, replacing the previous Add-on label. * In the collapsed view, app name and priority continue to appear alongside the new fields. * This is a UI text update only; no changes to task behavior, interactions, sorting, or filtering. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Maayan Hadasi <[email protected]>
Resolves: https://issues.redhat.com/browse/MTA-6046
Fixes: #2589
UI tests PR: 1663
Summary by CodeRabbit