Skip to content

Conversation

@mguetta1
Copy link
Collaborator

@mguetta1 mguetta1 commented Sep 2, 2025

Resolves: https://issues.redhat.com/browse/MTA-6046
Fixes: #2589

UI tests PR: 1663

Summary by CodeRabbit

  • Style
    • Updated Task Manager task titles: both expanded and collapsed states now display task ID and Kind, replacing the previous Add-on label.
    • In the collapsed view, app name and priority continue to appear alongside the new fields.
    • This is a UI text update only; no changes to task behavior, interactions, sorting, or filtering.

@coderabbitai
Copy link

coderabbitai bot commented Sep 2, 2025

Walkthrough

Replaced usage of task.addon with task.kind when constructing TaskItem titles in TaskManagerDrawer. Expanded titles now include id and kind. Collapsed titles now include id and kind while retaining appName and priority. No other logic, rendering, or API changes.

Changes

Cohort / File(s) Summary of Changes
Task Manager UI labels
client/src/app/components/task-manager/TaskManagerDrawer.tsx
Switched title construction from task.addon to task.kind for both expanded and collapsed TaskItem titles; now shows id and kind.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Assessment against linked issues

Objective Addressed Explanation
Correct task label: tech-discovery should not display as analyzer (#2589)

Assessment against linked issues: Out-of-scope changes

Code Change Explanation

Poem

I twitch my whiskers, glance at the screen,
“Kind,” not “addon,” now crisp and clean.
Tasks line up in proper attire,
No more analyzer in tech-discovery’s choir.
I thump my paw—UI made right,
Hop, hop, hooray through the pixel light! 🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
client/src/app/components/task-manager/TaskManagerDrawer.tsx (1)

154-158: Harden title formatting: avoid “undefined” and add a safe fallback to addon.

If applicationName is absent (e.g., platform tasks), the collapsed title will render “- undefined - …”. Also, in case kind is missing for any legacy tasks, falling back to addon keeps things readable.

Apply:

-  const title = expanded
-    ? `${task.id} (${task.kind})`
-    : `${task.id} (${task.kind}) - ${task.applicationName} - ${
-        task.priority ?? 0
-      }`;
+  const displayKind = task.kind || task.addon;
+  const subject = task.applicationName ?? task.platformName;
+  const title = expanded
+    ? `${task.id} (${displayKind})`
+    : `${task.id} (${displayKind})${subject ? ` - ${subject}` : ""} - ${task.priority ?? 0}`;
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a89124f and bc79f6f.

📒 Files selected for processing (1)
  • client/src/app/components/task-manager/TaskManagerDrawer.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: unit-test
  • GitHub Check: build-and-upload-for-global-ci
🔇 Additional comments (1)
client/src/app/components/task-manager/TaskManagerDrawer.tsx (1)

154-158: Good fix: using task.kind in the title meets the PR objective.

This change correctly surfaces the task kind (e.g., “tech-discovery”) and should resolve MTA-6046 in the apps drawer.

@sjd78 sjd78 changed the title 🐛 MTA-6046: Display task.kind in apps drawer 🐛 In the task drawer, show task kind instead of addon Sep 2, 2025
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mguetta1 mguetta1 closed this Sep 2, 2025
@mguetta1 mguetta1 reopened this Sep 2, 2025
@mguetta1 mguetta1 merged commit b9119ea into konveyor:main Sep 2, 2025
27 of 30 checks passed
@mguetta1 mguetta1 deleted the fix-task-name-apps-drawer branch September 2, 2025 21:01
sshveta pushed a commit to sshveta/tackle2-ui that referenced this pull request Oct 31, 2025
Resolves: https://issues.redhat.com/browse/MTA-6046
Fixes: konveyor#2589

UI tests PR: 1663

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Style**
* Updated Task Manager task titles: both expanded and collapsed states
now display task ID and Kind, replacing the previous Add-on label.
* In the collapsed view, app name and priority continue to appear
alongside the new fields.
* This is a UI text update only; no changes to task behavior,
interactions, sorting, or filtering.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Maayan Hadasi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tech-discovery task is displayed as analyzer

2 participants