✨ Finalize Source Platforms #2501
Conversation
WalkthroughThe changes update how platform providers are managed and displayed in the source platforms UI. The default and available providers are limited to "cloud-foundry", the provider list hook's return type is updated, and the UI disables the "Coordinates" tab. Imports and logic related to JSON schema rendering are removed or commented out. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Follow-up: konveyor#2368 Close gaps on source platform to match what is in the operator for konveyor-0.8: - provider list is just: [cloud-foundry] - platforms do no have schema defined coordinates Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
fixup_source_platforms
branch
from
9a37ee3 to
703a7a2
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
client/src/app/pages/source-platforms/usePlatformProviderList.ts (1)
3-3: Consider removing unnecessary sort operation.The
.sort()call on a single-element array is unnecessary and could be removed for clarity.-const PROVIDER_LIST = ["cloud-foundry"].sort(); +const PROVIDER_LIST = ["cloud-foundry"];client/src/app/pages/source-platforms/components/platform-detail-drawer.tsx (1)
93-104: Consider cleaning up unused TabKey enum value.The Coordinates tab is properly commented out with a clear TODO note. However, the
TabKey.Coordinatesenum value at line 30 is now unused and could be removed or commented out for consistency.enum TabKey { Details = 0, - Coordinates, + // Coordinates, // TODO: Add this back if Platforms need schema defined coordinates Applications, }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
client/src/app/pages/source-platforms/components/platform-detail-drawer.tsx(3 hunks)client/src/app/pages/source-platforms/components/platform-form/platform-form.tsx(1 hunks)client/src/app/pages/source-platforms/usePlatformProviderList.ts(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
client/src/app/pages/source-platforms/components/platform-form/platform-form.tsx (1)
client/src/app/pages/source-platforms/usePlatformProviderList.ts (1)
usePlatformProviderList(5-7)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-and-upload-for-global-ci
- GitHub Check: unit-test
🔇 Additional comments (4)
client/src/app/pages/source-platforms/usePlatformProviderList.ts (2)
1-1: LGTM! Default provider updated to align with operator 0.8.The change from "AWS" to "cloud-foundry" aligns with the PR objective to restrict providers for konveyor operator version 0.8 compatibility.
5-6: LGTM! Return type change correctly implemented.The hook now returns an object with a
providersproperty instead of returning the array directly. This change is properly reflected in the consuming components.client/src/app/pages/source-platforms/components/platform-detail-drawer.tsx (1)
18-18: LGTM! Unused imports removed.The removal of JSON schema-related imports aligns with disabling the Coordinates tab functionality.
client/src/app/pages/source-platforms/components/platform-form/platform-form.tsx (1)
62-62: LGTM! Correctly updated to match hook's new return signature.The destructuring properly extracts the
providersarray from the updatedusePlatformProviderListhook return value. This change maintains compatibility with the existing form logic.
Follow-up: konveyor#2368 Close gaps on source platform to match what is in the operator for konveyor-0.8: - provider list is just: [cloud-foundry] - platforms do no have schema defined coordinates Signed-off-by: Scott J Dickerson <[email protected]>
2 participants
Follow-up: #2368
Close gaps on source platform to match what is in the operator for konveyor-0.8:
Summary by CodeRabbit
New Features
Bug Fixes
Chores