-
Notifications
You must be signed in to change notification settings - Fork 51
🐛 always refresh the application query on application inventory #2346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://issues.redhat.com/browse/MTA-5181 For performance reasons, the application inventory page does not always refresh in the background. When there are no active tasks or imports, the application query does not auto-refresh. At the point where the app goes from having active tasks to no active tasks (e.g. running an analysis), it is possible that the auto-refresh is disabled before updates can be fetched. This is at most a 5 second window. To avoid this, when the tasks dashboard query goes from having active tasks to no active tasks, the application query is invalidated forcing the query to refresh its data. Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
66c2a39 to
ca6b23c
Compare
rszwajko
approved these changes
Jun 2, 2025
Collaborator
rszwajko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good decision!
github-actions bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
Resolves: https://issues.redhat.com/browse/MTA-5181 Historically and for performance reasons, the application inventory page tried to not always refresh in the background. The approach never really consistently worked, and if hub has a large number of applications, the refresh query logic would almost always run anyway. The refresh logic has been removed and the page will refresh the applications every 5 seconds. Performance issues may emerge in a large environment and #2350 was written to capture what is known and have some ideas about how to approach a solution. --------- Signed-off-by: Scott J Dickerson <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
sjd78
pushed a commit
that referenced
this pull request
Jun 2, 2025
… (#2353) Resolves: https://issues.redhat.com/browse/MTA-5181 Historically and for performance reasons, the application inventory page tried to not always refresh in the background. The approach never really consistently worked, and if hub has a large number of applications, the refresh query logic would almost always run anyway. The refresh logic has been removed and the page will refresh the applications every 5 seconds. Performance issues may emerge in a large environment and #2350 was written to capture what is known and have some ideas about how to approach a solution. --------- Signed-off-by: Scott J Dickerson <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
This was referenced Jul 16, 2025
This was referenced Aug 22, 2025
This was referenced Sep 8, 2025
This was referenced Sep 29, 2025
sshveta
pushed a commit
to sshveta/tackle2-ui
that referenced
this pull request
Oct 31, 2025
…eyor#2346) Resolves: https://issues.redhat.com/browse/MTA-5181 Historically and for performance reasons, the application inventory page tried to not always refresh in the background. The approach never really consistently worked, and if hub has a large number of applications, the refresh query logic would almost always run anyway. The refresh logic has been removed and the page will refresh the applications every 5 seconds. Performance issues may emerge in a large environment and konveyor#2350 was written to capture what is known and have some ideas about how to approach a solution. --------- Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/MTA-5181
Historically and for performance reasons, the application inventory page tried to not always refresh in the background. The approach never really consistently worked, and if hub has a large number of applications, the refresh query logic would almost always run anyway.
The refresh logic has been removed and the page will refresh the applications every 5 seconds.
Performance issues may emerge in a large environment and #2350 was written to capture what is known and have some ideas about how to approach a solution.