🐛 [backport release-0.6] Update the bulk selector to only consider the current page (#2197) #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r#2197) Resolves: https://issues.redhat.com/browse/MTA-4685 For tables with row selection, update the bulk selection component so that it works consistently across client local and server managed filter/sort/pagination. With this change, the bulk selector will allow: - Allow clearing all selections - Allow selecting all row in the current page - Show the count of selected rows Client local tables could support additional selections such as "select all filtered rows", and "select all rows". At this time, maintaining consistency across tables is better than segmenting bulk selection functionality depending on table data source type. Only select none and select current page is supported. Summary of changes: - Split expansion logic out of `ToolbarBulkSelector` to `ToolbarBulkExpander` (do one thing per component) - Remove unused `isItemSelectable` prop from the `useSelectionState()` hook - Move data functionality out of `ToolbarBulkSelector` into `useBulkSelector()` to keep data handling separate from the render - Refactor to simplify `useSelectionState()` and move selection tracking out of `useTableContolProps()` --------- Signed-off-by: Scott J Dickerson <[email protected]>
rszwajko
approved these changes
Mar 19, 2025
This was referenced Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/MTA-4685
For tables with row selection, update the bulk selection component so that it works consistently across client local and server managed filter/sort/pagination. With this change, the bulk selector will allow:
Client local tables could support additional selections such as "select all filtered rows", and "select all rows". At this time, maintaining consistency across tables is better than segmenting bulk selection functionality depending on table data source type. Only select none and select current page is supported.
Summary of changes:
ToolbarBulkSelectortoToolbarBulkExpander(do one thing per component)isItemSelectableprop from theuseSelectionState()hookToolbarBulkSelectorintouseBulkSelector()to keep data handling separate from the renderuseSelectionState()and move selection tracking out ofuseTableContolProps()