✨ Support list all application identities. #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
jortel
commented
Jun 4, 2025
| ID: identity.ID, | ||
| Name: identity.Name, | ||
| }) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
hint: Replace the identities with result of /applications/:id/identities which includes defaults.
jortel
commented
Jun 4, 2025
| for i := range indirect { | ||
| m := &indirect[i] | ||
| if _, found := mp[m.Kind]; found { | ||
| continue |
Contributor
Author
There was a problem hiding this comment.
hint: Direct mapping take priority.
Member
|
Coolstore analysis produces failure below, I will test other PRs to be sure it is not coming from changes in PRs. |
aufi
approved these changes
Jun 9, 2025
Member
|
CI fails on known issue, not blocking merge. |
jortel
added a commit
to konveyor/tackle2-addon-analyzer
that referenced
this pull request
Jun 14, 2025
requires: konveyor/tackle2-hub#832 --------- Signed-off-by: Jeff Ortel <[email protected]>
This was referenced Jul 16, 2025
This was referenced Aug 22, 2025
This was referenced Sep 8, 2025
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add: /applications/:id/identities to list all identities (including defaults) for all kinds.
Inject default creds in addon adapter Application() method.
Required by:
Incidental: Small refactor/re-org of Application binding for consistency.