🐛 Fix seed dup target labels #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
jortel
commented
Jan 23, 2025
| target.Provider = t.Provider | ||
| target.Choice = t.Choice | ||
| target.ImageID = f.ID | ||
| target.Labels = []model.TargetLabel{} |
Contributor
Author
There was a problem hiding this comment.
hint: This is the main fix ^.
aufi
approved these changes
Jan 24, 2025
Member
aufi
left a comment
aufi
left a comment
There was a problem hiding this comment.
The fix looks good to me, git command in container-build scripts setting hub-build probably needs some update.
83.41 git describe --match "v[0-9]*" --tags HEAD > bin/.build
83.41 fatal: No names found, cannot describe anything.
Contributor
Author
I think it just needs --always flag. |
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
jortel
added
the
cherry-pick/release-0.6
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Fixes an issue with duplicate target labels. Also, add support for a hub build version needed to detect upgrades. The git _tag-hash_ is written to `/etc/hub-build`. The _abbreviated_ commit hash is appended when HEAD is a commit added to the latest label. Examples: ``` v0.6.0-beta.1-1-e161635 # tag+hash v0.6.0-beta.1-1 # tag only e161635 # hash only ``` After seeded, the build is stored in settings: `.hub.db.seed.build`. This is compared with current build to detect when the build has changed. Seeding is _skipped_ when both the build (version) and the seed data have not changed. --- The go.mod update was to bump go-utils for better logging of objects. Included here for better logging of the _Settings_. --------- Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
jortel
added a commit
that referenced
this pull request
Jan 24, 2025
Fixes an issue with duplicate target labels. Also, add support for a hub build version needed to detect upgrades. The git _tag-hash_ is written to `/etc/hub-build`. The _abbreviated_ commit hash is appended when HEAD is a commit added to the latest label. Examples: ``` v0.6.0-beta.1-1-e161635 # tag+hash v0.6.0-beta.1-1 # tag only e161635 # hash only ``` After seeded, the build is stored in settings: `.hub.db.seed.build`. This is compared with current build to detect when the build has changed. Seeding is _skipped_ when both the build (version) and the seed data have not changed. --- The go.mod update was to bump go-utils for better logging of objects. Included here for better logging of the _Settings_. --------- Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Jeff Ortel <[email protected]>
This was referenced Mar 7, 2025
This was referenced May 21, 2025
This was referenced Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with duplicate target labels.
Also, add support for a hub build version needed to detect upgrades.
The git tag-hash is written to
/etc/hub-build. The abbreviated commit hash is appended when HEAD is a commit added to the latest label.Examples:
After seeded, the build is stored in settings:
.hub.db.seed.build. This is compared with current build to detect when the build has changed. Seeding is skipped when both the build (version) and the seed data have not changed.The go.mod update was to bump go-utils for better logging of objects. Included here for better logging of the Settings.