Skip to content

Conversation

@aufi
Copy link
Member

@aufi aufi commented Nov 25, 2024

CSV importer code used to set the last existing BussinessService to an Application, updating businessService variable from Ref to Value to keep the found BusinessService until it is saved in Application.

Fixes: https://issues.redhat.com/browse/MTA-4257

CSV importer code used to set the last existing BussinessService to an
Application, updating businessService variable from Ref to Value to keep
the found BusinessService until it is saved in Application.

Fixes: https://issues.redhat.com/browse/MTA-4257

Signed-off-by: Marek Aufart <[email protected]>
@aufi aufi requested a review from jortel November 25, 2024 14:12
@aufi
Copy link
Member Author

aufi commented Nov 25, 2024

Local testing&reproduces steps:

Run Hub

$ rm /tmp/tackle.db
$ DISCONNECTED=1 make run

Import first CSV

$ curl -F "[email protected]" localhost:8080/importsummaries/upload

Import additional CSV

$ curl -F "[email protected]" localhost:8080/importsummaries/upload

Check app's BusinessServices:

$ curl localhost:8080/applications | jq | grep -A2 business

Main without this PR has the last application AAAA incorrect business service Finance and HR, with this PR, it has expected Retail.

CSV files are attached to original JIRA ticket (link in description).

@aufi aufi added the cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch label Nov 25, 2024
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aufi aufi added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch. label Nov 25, 2024
@aufi aufi merged commit fd98244 into konveyor:main Nov 25, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
CSV importer code used to set the last existing BussinessService to an
Application, updating businessService variable from Ref to Value to keep
the found BusinessService until it is saved in Application.

Fixes: https://issues.redhat.com/browse/MTA-4257

Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
CSV importer code used to set the last existing BussinessService to an
Application, updating businessService variable from Ref to Value to keep
the found BusinessService until it is saved in Application.

Fixes: https://issues.redhat.com/browse/MTA-4257

Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
aufi added a commit that referenced this pull request Nov 26, 2024
CSV importer code used to set the last existing BussinessService to an
Application, updating businessService variable from Ref to Value to keep
the found BusinessService until it is saved in Application.

Fixes: https://issues.redhat.com/browse/MTA-4257

Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Marek Aufart <[email protected]>
aufi added a commit that referenced this pull request Nov 26, 2024
CSV importer code used to set the last existing BussinessService to an
Application, updating businessService variable from Ref to Value to keep
the found BusinessService until it is saved in Application.

Fixes: https://issues.redhat.com/browse/MTA-4257

Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Marek Aufart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch. cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants