Skip to content

Conversation

@jortel
Copy link
Contributor

@jortel jortel commented Dec 16, 2024

Support injecting general settings (Resources) into extension configuration.
Example:

  metadata:
    provider:
      address: localhost:$(PORT)
      initConfig:
      - providerSpecificConfig:
          mavenInsecure: $(maven.insecure)
          mavenSettingsFile: $(maven.settings.path)
      name: java
    resources:
    - fields:
      - key: maven.settings.path
        name: settings
        path: /shared/creds/maven/settings.xml
      selector: identity:kind=maven
    - fields:
      - key: maven.insecure
        name: value
      selector: setting:key=mvn.insecure.enabled

Copy link
Contributor

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jortel jortel added the cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch label Dec 18, 2024
@jortel jortel merged commit b3937d3 into konveyor:main Dec 18, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
Support injecting _general_ settings (Resources) into extension
configuration.
Example:
```
  metadata:
    provider:
      address: localhost:$(PORT)
      initConfig:
      - providerSpecificConfig:
          mavenInsecure: $(maven.insecure)
          mavenSettingsFile: $(maven.settings.path)
      name: java
    resources:
    - fields:
      - key: maven.settings.path
        name: settings
        path: /shared/creds/maven/settings.xml
      selector: identity:kind=maven
    - fields:
      - key: maven.insecure
        name: value
      selector: setting:key=mvn.insecure.enabled

```

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
jortel added a commit that referenced this pull request Dec 20, 2024
Support injecting _general_ settings (Resources) into extension
configuration.
Example:
```
  metadata:
    provider:
      address: localhost:$(PORT)
      initConfig:
      - providerSpecificConfig:
          mavenInsecure: $(maven.insecure)
          mavenSettingsFile: $(maven.settings.path)
      name: java
    resources:
    - fields:
      - key: maven.settings.path
        name: settings
        path: /shared/creds/maven/settings.xml
      selector: identity:kind=maven
    - fields:
      - key: maven.insecure
        name: value
      selector: setting:key=mvn.insecure.enabled

```

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Jeff Ortel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants