-
Notifications
You must be signed in to change notification settings - Fork 43
🐛 add kai to make-bundle action #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Fabian von Feilitzsch <[email protected]>
Signed-off-by: Fabian von Feilitzsch <[email protected]>
WalkthroughAdded optional input kai to the Make Operator Bundle GitHub Action and updated the bundle step to conditionally pass Helm value images.kai when the input is provided. No other logic changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User as Workflow Caller
participant Action as make-bundle Action
participant Script as Bundle Script
participant Helm as Helm
User->>Action: Provide inputs (kai optional)
Action->>Script: Build OPTS from inputs
alt kai provided
Script->>Script: Append "--set images.kai=${kai}" to OPTS
else kai empty
Script->>Script: No change to OPTS for kai
end
Script->>Helm: helm template/install with OPTS
Helm-->>Action: Bundle artifacts
Action-->>User: Output bundle
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Fabian von Feilitzsch <[email protected]>
Co-authored-by: David Zager <[email protected]> Signed-off-by: Fabian von Feilitzsch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/actions/make-bundle/action.yml (1)
88-88: Consider --set-string and quoting to avoid shell/Helm coercion issuesCurrent pattern mirrors existing inputs and will work. To make it more robust (and future-safe for tags like “1.0” or user-provided strings with special chars), prefer --set-string and quote the value to prevent shell parsing/command substitution and Helm type coercion.
- [ -n "${{ inputs.kai }}" ] && OPTS+=" --set images.kai=${{ inputs.kai }}" + [ -n "${{ inputs.kai }}" ] && OPTS+=" --set-string images.kai='${{ inputs.kai }}'"Note: For consistency, consider applying the same --set-string + quoting to other image inputs in a follow-up.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/actions/make-bundle/action.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: run-ci / e2e-api-integration-tests
Summary by CodeRabbit