Skip to content

Conversation

@fabianvf
Copy link
Contributor

@fabianvf fabianvf commented Aug 19, 2025

Summary by CodeRabbit

  • New Features
    • The Make Operator Bundle GitHub Action now supports an optional input to specify the Kai image URI, enabling customization of the image used during bundle generation.
    • When provided, the Kai image is automatically applied to the build configuration; if omitted, the action behaves as before with no changes required.
    • No other inputs or behavior are affected.

Signed-off-by: Fabian von Feilitzsch <[email protected]>
Signed-off-by: Fabian von Feilitzsch <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Aug 19, 2025

Walkthrough

Added optional input kai to the Make Operator Bundle GitHub Action and updated the bundle step to conditionally pass Helm value images.kai when the input is provided. No other logic changed.

Changes

Cohort / File(s) Summary
GitHub Action: make-bundle
.github/actions/make-bundle/action.yml
Introduced optional input kai (default ""), and in the build step conditionally appends --set images.kai=<value> to OPTS when kai is non-empty.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User as Workflow Caller
  participant Action as make-bundle Action
  participant Script as Bundle Script
  participant Helm as Helm

  User->>Action: Provide inputs (kai optional)
  Action->>Script: Build OPTS from inputs
  alt kai provided
    Script->>Script: Append "--set images.kai=${kai}" to OPTS
  else kai empty
    Script->>Script: No change to OPTS for kai
  end
  Script->>Helm: helm template/install with OPTS
  Helm-->>Action: Bundle artifacts
  Action-->>User: Output bundle
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at flags that fly,
A tiny hop adds image.kai.
In OPTS I stash this shiny string,
Then helm and bundles do their thing.
Carrots, charts, and CI glow—
One more nibble, off we go! 🥕🚀

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fabianvf fabianvf changed the title add kai to make-bundle action 🐛 add kai to make-bundle action Aug 19, 2025
Signed-off-by: Fabian von Feilitzsch <[email protected]>
Co-authored-by: David Zager <[email protected]>
Signed-off-by: Fabian von Feilitzsch <[email protected]>
@djzager djzager changed the title 🐛 add kai to make-bundle action 🐛 add kai to make-bundle action Aug 19, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/actions/make-bundle/action.yml (1)

88-88: Consider --set-string and quoting to avoid shell/Helm coercion issues

Current pattern mirrors existing inputs and will work. To make it more robust (and future-safe for tags like “1.0” or user-provided strings with special chars), prefer --set-string and quote the value to prevent shell parsing/command substitution and Helm type coercion.

-      [ -n "${{ inputs.kai }}" ] && OPTS+=" --set images.kai=${{ inputs.kai }}"
+      [ -n "${{ inputs.kai }}" ] && OPTS+=" --set-string images.kai='${{ inputs.kai }}'"

Note: For consistency, consider applying the same --set-string + quoting to other image inputs in a follow-up.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fd81a89 and d61e7b8.

📒 Files selected for processing (1)
  • .github/actions/make-bundle/action.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: run-ci / e2e-api-integration-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants