-
Notifications
You must be signed in to change notification settings - Fork 43
✨ Improved java logging. #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jeff Ortel <[email protected]>
WalkthroughA new environment variable, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
roles/tackle/templates/customresource-extension.yml.j2 (1)
26-30: LGTM! Logging configuration aligns with PR objectives.The addition of
JAVA_TOOL_OPTIONSwith comprehensive JDT Language Server logging configuration is well-implemented and directly addresses the PR objective of improving Java logging. The YAML syntax using folded block scalar (>) is appropriate for the multi-line value.Consider the following for production deployments:
- Monitor log volume impact, as
ALLlevel logging can be quite verbose- Evaluate performance implications of detailed logging in high-throughput scenarios
- Consider making logging level configurable via template variables if different environments need different verbosity levels
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
roles/tackle/templates/customresource-extension.yml.j2(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-operator-bundle
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. |
This makes jdtls send additional log entries to the provider which end up in the container log. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Enabled detailed logging for the Java language server by setting advanced logging options, providing enhanced visibility into server activity for troubleshooting and diagnostics. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
This makes jdtls send additional log entries to the provider which end up in the container log.
Summary by CodeRabbit