✨ Feature/add pipe connection #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
force-pushed
the
feature/add-pipe-connection
branch
from
7b4ae34 to
fcb4d4f
Compare
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
feature/add-pipe-connection
branch
from
fcb4d4f to
4ff1546
Compare
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
commented
Apr 14, 2025
shawn-hurley
commented
Apr 14, 2025
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
feature/add-pipe-connection
branch
2 times, most recently
from
c1d222d to
fdb94fd
Compare
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
feature/add-pipe-connection
branch
from
5047c15 to
5cbbd80
Compare
| bundles := flag.String("bundles", "", "Comma separated list of path to java analyzer bundles") | ||
| depOpenSourceLabelsFile := flag.String("depOpenSourceLabelsFile", "", "Path to the dep open source labels file") | ||
| pipePath := flag.String("pipePath", "", "Path to the pipe to use for bi-directional communication") | ||
| logVerbosity := flag.Int("verbosity", -4, "how verbose would you like the logs to be, error logs are 8, warning logs are 4 info logs are 0 and debug logs are -4, going more negative gives more logs.") |
Contributor
There was a problem hiding this comment.
Just FYI, I have another PR which uses levels strings, so that we can expose it directly in vscode config. This is fine for now. I will rebase my PR
| // Read implements io.ReadWriteCloser. | ||
| func (c Connection) Read(p []byte) (n int, err error) { | ||
| r, err := c.Input.Read(p) | ||
| c.Logger.Info("read from connection", "bytes read", r, "error", err, "bytes", string(p)) |
Contributor
There was a problem hiding this comment.
I wonder if we should bump this level because we are already logging this in the codec
| p := extjava.NewJavaProvider(log, "java", contextLines, provider.Config{ | ||
| Name: "java", | ||
| }) | ||
| log.Info("logger", "v", p) |
Contributor
There was a problem hiding this comment.
change text and bump level?
| p := extjava.NewJavaProvider(log, "java", contextLines, provider.Config{ | ||
| Name: "java", | ||
| }) | ||
| log.Info("logger", "v", p) |
Contributor
There was a problem hiding this comment.
change text and bump level?
| p := extjava.NewJavaProvider(log, "java", contextLines, provider.Config{ | ||
| Name: "java", | ||
| }) | ||
| log.Info("logger", "v", p) |
pranavgaikwad
approved these changes
Apr 30, 2025
Contributor
pranavgaikwad
left a comment
pranavgaikwad
left a comment
There was a problem hiding this comment.
Ill address my comments after this is merged. They are minor
djzager
added a commit
to konveyor/editor-extensions
that referenced
this pull request
May 1, 2025
Signed-off-by: Shawn Hurley <[email protected]> Needs: konveyor/kai#763 Fixes #471 Fixes #469 --------- Signed-off-by: Shawn Hurley <[email protected]> Signed-off-by: David Zager <[email protected]> Co-authored-by: Shawn Hurley <[email protected]> Co-authored-by: David Zager <[email protected]>
This was referenced Jul 16, 2025
This was referenced Aug 22, 2025
This was referenced Sep 8, 2025
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs: konveyor/analyzer-lsp#815