-
Notifications
You must be signed in to change notification settings - Fork 20
✨ Update Dockerfile to move to maven 3.9.11 #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dylan Murray <[email protected]>
WalkthroughThe Dockerfile was modified to update the Maven download and installation from version 3.9.10 to 3.9.11. The download URL, symbolic link for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
Dockerfile (1)
33-37: Mismatch: symlink &M2_HOMEstill point to 3.9.10 – build will boot Maven 3.9.10, not 3.9.11.Only the tarball URL was bumped; the rest of the install script still references the old directory.
At runtimemvn -vwill report 3.9.10 if that folder happens to exist (e.g., from layer cache) or will fail with “No such file or directory” in a clean build.Fix all hard-coded version strings in the block:
RUN curl -fsSL -o /tmp/apache-maven.tar.gz https://dlcdn.apache.org/maven/maven-3/3.9.11/binaries/apache-maven-3.9.11-bin.tar.gz && \ tar -xzf /tmp/apache-maven.tar.gz -C /usr/local/ && \ - ln -s /usr/local/apache-maven-3.9.10/bin/mvn /usr/bin/mvn && \ + ln -s /usr/local/apache-maven-3.9.11/bin/mvn /usr/bin/mvn && \ rm /tmp/apache-maven.tar.gz -ENV M2_HOME /usr/local/apache-maven-3.9.10 +ENV M2_HOME /usr/local/apache-maven-3.9.11Optionally deduplicate the version number with a build arg to avoid future drift.
🧹 Nitpick comments (1)
Dockerfile (1)
33-34: (Optional) add checksum verification for the Maven tarballBlind
curl+tarleaves the supply chain unverified. Consider adding a SHA-512 check published by Apache to fail fast on tampering or network corruption.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: e2e / e2e-api-integration-tests
- GitHub Check: e2e / e2e-ui-integration-tests
- GitHub Check: e2e / e2e-api-integration-tests
- GitHub Check: e2e / e2e-ui-integration-tests
Signed-off-by: Shawn Hurley <[email protected]>
Summary by CodeRabbit