🐛 Make compilation unit consistant with underlying resource #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We need to make sure that the compilation unit is consistant with the underlying resource before we look for the location. * Changes to the filesystem are reflected correctly in the search match, but are not reflected in the compilation unit, so we need to force it to become consistant. * Fixed a bug in a regex replace that caused every char to be changed to "/" * Fixed a potential bug, where for a multipattern seach match, we could have overwrites of the specific SymbolProvider. Signed-off-by: Shawn Hurley <[email protected]>
|
|
||
| // check if the match was found in the same package as the query was looking for | ||
| if (queryQualification != "" && location.getUri().contains(queryQualification.replaceAll(".", "/"))) { | ||
| if (queryQualification != "" && location.getUri().contains(queryQualification.replaceAll("\\.", "/"))) { |
Contributor
There was a problem hiding this comment.
what's with \\.? It isn't a regex, no?
Contributor
Author
There was a problem hiding this comment.
it escapes the . to actually change just the '.' character and not every character. what was happening is that the replaced string was ////////////////
This was referenced Mar 7, 2025
This was referenced Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #122