Skip to content

🐛 adding updates to get lang ext working #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

🐛 adding updates to get lang ext working #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8328df2
adding updates to get lang ext working
savitharaghunathan Nov 7, 2025
6f9bfc8
issue with this fix and the test for using an exisitng socket for a l…
shawn-hurley Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lsp/base_service_client/base_capabilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ type ReferencedCondition struct {
// references.
func EvaluateReferenced[T base](t T, ctx ctx, cap string, info []byte) (resp, error) {
sc := t.GetLSPServiceClientBase()
sc.Log.Info("Evaluate Call", "cap", cap, "info", info)

var cond ReferencedCondition
err := yaml.Unmarshal(info, &cond)
Expand Down
4 changes: 4 additions & 0 deletions lsp/base_service_client/base_service_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ func NewLSPServiceClientBase(
} else {
sc.Log.Info("using provided connection", "conn", c.RPC)
sc.Conn = c.RPC
sc.ServerCapabilities = protocol.ServerCapabilities{
AssumeWorks: true,
}
}
// Create the caches for the various handler stuffs
sc.PublishDiagnosticsCache = NewAwaitCache[string, []protocol.Diagnostic]()
Expand Down Expand Up @@ -353,6 +356,7 @@ func (sc *LSPServiceClientBase) GetAllDeclarations(ctx context.Context, workspac
// Client may or may not support the "workspace/symbol" method, so we must
// check before calling.

sc.Log.Info("server caps", "supports", sc.ServerCapabilities.Supports("workspace/symbol"))
if sc.ServerCapabilities.Supports("workspace/symbol") {
params := protocol.WorkspaceSymbolParams{
Query: query,
Expand Down
3 changes: 3 additions & 0 deletions lsp/protocol/extensions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ package protocol
// FIXME: Implement all requests!
// TODO: Evaluate tradeoffs of turning this into a map?
func (c *ServerCapabilities) Supports(method string) bool {
if c.AssumeWorks {
return true
}
Comment on lines +8 to +10
Copy link

@coderabbitai coderabbitai bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Do not globally bypass capability checks; narrow the scope

Global early-return on AssumeWorks defeats the guard that prevents sending unsupported methods to servers that may crash (as noted in the file header). This is a high‑risk regression.

Constrain the bypass to an explicit, minimal allowlist (e.g., only the method you need to unblock), and fall back to existing switch logic otherwise. Example:

-	if c.AssumeWorks {
-		return true
-	}
+	if c.AssumeWorks {
+		switch method {
+		case "workspace/symbol":
+			return true
+		}
+	}

If more methods are required, make the list configurable per provider rather than blanket enabling.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In lsp/protocol/extensions.go around lines 8-10, the code currently returns true
unconditionally when c.AssumeWorks is set which bypasses all capability checks;
change this to only bypass for a minimal allowlist of explicit method names (or
provider-configurable list) by checking if the requested method is in that
allowlist and return true only in that case, otherwise fall through to the
existing switch/capability logic so unsupported methods are still guarded
against.

switch method {
// case "$/cancelRequest":
// case "$/logTrace":
Expand Down
1 change: 1 addition & 0 deletions lsp/protocol/tsprotocol.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions provider/grpc/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,10 @@ func (g *grpcProvider) Init(ctx context.Context, log logr.Logger, config provide
return nil, provider.InitConfig{}, err
}

if config.PipeName != "" {
config.Initialized = true
}

g.log.Info("provider configuration", "config", config)
c := pb.Config{
Location: config.Location,
Expand Down
2 changes: 1 addition & 1 deletion provider/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ func (s *server) Init(ctx context.Context, config *libgrpc.Config) (*libgrpc.Ini
NoProxy: config.Proxy.NoProxy,
},
PipeName: config.LanguageServerPipe,
Initialized: config.Initialized,
Initialized: config.LanguageServerPipe != "",
}

newCtx := context.Background()
Expand Down
3 changes: 1 addition & 2 deletions provider_pod_local_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"dependencyFolders": [],

"dependencyProviderPath": "/usr/local/bin/golang-dependency-provider"
},
"pipeName": "/tmp/go-pls-pipe-test"
}
}]
},
{
Expand Down
Loading