🐛 fix minor bug in perl for macos

[pranavgaikwad]

Summary by CodeRabbit

• Bug Fixes
  • Corrected batch handling in file content search on macOS, improving result accuracy and preventing over-scanning.
• Performance
  • Optimized the macOS search pipeline to process files batch-by-batch, reducing overhead on large searches.
• Reliability
  • Improved end-of-file handling during searches, producing more consistent and well-formed results.

[coderabbitai]

Walkthrough

Darwin-specific file search now builds the file list from the current batch rather than all locations. The xargs/perl pipeline’s Perl snippet was changed to conditionally print matches and explicitly close ARGV at EOF, altering output generation and input handling for each batch.

Changes

Cohort / File(s)	Summary
Darwin file search batching and Perl pipeline provider/internal/builtin/service_client.go	In performFileContentSearch (Darwin branch): switched fileList construction to iterate over currBatch instead of locations; updated Perl command from simple match/print to conditional printing with explicit ARGV close at EOF within the xargs/perl pipeline.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Caller
  participant ServiceClient
  participant BatchIterator as Batch Iterator
  participant Xargs
  participant Perl

  Caller->>ServiceClient: performFileContentSearch(pattern, locations)
  ServiceClient->>BatchIterator: Partition locations into currBatch
  loop For each currBatch (Darwin)
    ServiceClient->>Xargs: Pass currBatch file list
    Xargs->>Perl: Invoke Perl with regex pattern
    alt Line matches pattern
      Perl-->>Xargs: Print "file:line:$1"
    else No match
      Perl-->>Xargs: (no output)
    end
    note over Perl: On EOF for a file<br/>close ARGV
    Xargs-->>ServiceClient: Aggregated matches for batch
  end
  ServiceClient-->>Caller: Combined results

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I thump through code with tidy cheer,
Batch by batch, the files draw near.
A Perl-ish whisper, lines align—
Print on match, then end the line.
ARGV closed, the search made tight,
A rabbit nods: “The flow feels right.” 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Title Check	✅ Passed	The title indicates a Perl bug fix on macOS, which aligns with the Darwin-specific adjustments to the Perl invocation and batch iteration in the changeset, and it clearly reflects the main purpose of the PR.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}