🐛 Use correct generic service client builder/fix Node.js prov #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemcmullan
force-pushed
the
node-provider
branch
2 times, most recently
from
2a6c2c5 to
c37f822
Compare
eemcmullan
force-pushed
the
node-provider
branch
from
c37f822 to
ca39bf1
Compare
external-providers/generic-external-provider/pkg/generic_external_provider/provider.go
Show resolved
Hide resolved
| var symbols []protocol.WorkspaceSymbol | ||
| for batchRight < len(nodeFiles) { | ||
| for batchRight-batchLeft < BATCH_SIZE && batchRight < len(nodeFiles) { | ||
| text, err := os.ReadFile(nodeFiles[batchRight][7:]) |
Contributor
There was a problem hiding this comment.
is nodeFiles a 2D slice? what is 7?
Contributor
Author
There was a problem hiding this comment.
Updated this to be more readable
Signed-off-by: Emily McMullan <[email protected]>
Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
node-provider
branch
from
ca39bf1 to
49bbb43
Compare
Signed-off-by: Emily McMullan <[email protected]>
pranavgaikwad
approved these changes
Apr 22, 2025
This was referenced May 21, 2025
This was referenced Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.