🐛 fix nil check for cond.referenced.filepaths #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Gaikwad <[email protected]>
fabianvf
reviewed
Feb 27, 2025
| return provider.ProviderEvaluateResponse{}, fmt.Errorf("unable to get query info: %v", err) | ||
| } | ||
| // filepaths get rendered as a string and must be converted | ||
| if cond.Referenced.Filepaths != nil { |
Contributor
There was a problem hiding this comment.
is it guaranteed to not be nil?
Contributor
Author
There was a problem hiding this comment.
@fabianvf In golang, len() implicitly returns 0 when slice is nil
aufi
approved these changes
Feb 28, 2025
shawn-hurley
approved these changes
Feb 28, 2025
Contributor
shawn-hurley
left a comment
shawn-hurley
left a comment
There was a problem hiding this comment.
I have the same local cha ge I haven't pushed up yet
This was referenced Mar 7, 2025
This was referenced May 21, 2025
This was referenced Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.