Skip to content

🐛 make sure non java files are exploded to java project#760

Merged
pranavgaikwad merged 3 commits into
konveyor:mainfrom
pranavgaikwad:fixJarExplosion
Jan 15, 2025
Merged

🐛 make sure non java files are exploded to java project#760
pranavgaikwad merged 3 commits into
konveyor:mainfrom
pranavgaikwad:fixJarExplosion

Conversation

@pranavgaikwad
Copy link
Copy Markdown
Contributor

@pranavgaikwad pranavgaikwad commented Jan 14, 2025

API Tests PR: 249

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@dymurray dymurray added the cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch label Jan 14, 2025
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Copy link
Copy Markdown
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aufi
Copy link
Copy Markdown
Member

aufi commented Jan 15, 2025

Regarding to test failures, failed acmeair-webapp and tackle-testapp-binary added an issue in .properties file which looks good and API tests should be updated (as well as Tags) in follow-up PR to go-konveyor-tests.

However, administracion-efectivo cannot find any issue now (local-storage-00001 and local-storage-00002 from .java files were expected), which looks strange and probabaly needs some care on analyzer side (test case: https://github.com/konveyor/go-konveyor-tests/blob/main/analysis/tc_administracion_efectivo_upload_binary.go)

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad merged commit 2f9344a into konveyor:main Jan 15, 2025
github-actions Bot pushed a commit that referenced this pull request Jan 15, 2025
API Tests PR: 249

---------

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
dymurray pushed a commit that referenced this pull request Jan 15, 2025
---------

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
dymurray added a commit that referenced this pull request Jan 15, 2025
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants