✨ Adding a Scope to the running of the rule engine #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
force-pushed
the
feature/add-included-paths-to-running-rules-engine
branch
4 times, most recently
from
f3a216b to
cb967a1
Compare
shawn-hurley
commented
Nov 20, 2024
Contributor
Author
shawn-hurley
left a comment
shawn-hurley
left a comment
There was a problem hiding this comment.
Updating based on my review
external-providers/java-external-provider/pkg/java_external_provider/service_client.go
Outdated
Show resolved
Hide resolved
shawn-hurley
force-pushed
the
feature/add-included-paths-to-running-rules-engine
branch
from
cb967a1 to
6e806c4
Compare
shawn-hurley
force-pushed
the
feature/add-included-paths-to-running-rules-engine
branch
3 times, most recently
from
49c5fe4 to
85d9b4e
Compare
…he running engine and the caller of run rules add scoped run rules to interface Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
feature/add-included-paths-to-running-rules-engine
branch
from
85d9b4e to
e25c077
Compare
jmle
reviewed
Nov 21, 2024
jmle
reviewed
Nov 21, 2024
jmle
approved these changes
Nov 21, 2024
jmle
approved these changes
Nov 22, 2024
This was referenced Mar 7, 2025
This was referenced May 21, 2025
This was referenced Jun 11, 2025
shawn-hurley
deleted the
feature/add-included-paths-to-running-rules-engine
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scope will allow for users to call the engine directly will be able to add information to the condition context. Providers are still responsible for restricting based on that condition context.
Working off of @jmle awesome work to get the file paths respected in providers