Conversation
|
Update on the testing note - to update the Kubefirst Pro API/UI, use the |
mrsimonemms
left a comment
There was a problem hiding this comment.
LGTM. To test this I:
- installed Vultr
- created a physical cluster from the console
- installed Flappy KRay
- achieved a record high score (11 - yes, I'm rubbish at it)
- deleted the physical cluster from the console
- done a small dance
There are a couple of nits that I'd like fixing in the code please:
- couple of files without a trailing whitespace
- please also run
terraform formaton the changed files
I'm planning on adding a CI job to check these linting issues in the near future.
|
Hi @mrsimonemms ,i did use |
|
Did you do it at the root of the project, or for the specific files changed (ie, There are definitely some formatting changes that I'd expect to see. |
|
Hi @mrsimonemms ,when i formatted indiviual file it worked,i pushed the changes and even added gitlab support as well |
|
It probably would have been better to keep GitHub and GitLab changes in separate PRs as this is now a very big PR. Can you remove the GitLab commit and put it in a separate PR please? |
6902e95 to
e84b279
Compare
|
reverted changes @mrsimonemms 👍 |
mrsimonemms
left a comment
There was a problem hiding this comment.
Some stylistic nits.
Are you using EditorConfig in your IDE? This will automate most of these away for you.
vultr-github/templates/gpu-cluster/cloudflare-origin-issuer/cloudflare-issuer.yaml
Outdated
Show resolved
Hide resolved
vultr-github/templates/gpu-cluster/45-cloudflare-origin-issuer.yaml
Outdated
Show resolved
Hide resolved
vultr-github/templates/gpu-cluster/41-cloudflare-origin-ca-issuer.yaml
Outdated
Show resolved
Hide resolved
vultr-github/templates/gpu-cluster/40-cloudflare-origin-issuer-crd.yaml
Outdated
Show resolved
Hide resolved
vultr-github/templates/gpu-cluster/workload-cluster-environment/metaphor.yaml
Outdated
Show resolved
Hide resolved
vultr-github/templates/workload-cluster/45-cloudflare-origin-issuer.yaml
Outdated
Show resolved
Hide resolved
vultr-github/templates/workload-cluster/cloudflare-origin-issuer/cloudflare-issuer.yaml
Outdated
Show resolved
Hide resolved
vultr-github/templates/workload-cluster/workload-cluster-environment/metaphor.yaml
Outdated
Show resolved
Hide resolved
|
thank you Simon ❤️ |
Description
Implemented functionality to provision physical clusters within the Vultr environment. This update includes the addition of a GPU-cluster template, although the integration of the NVIDIA operator is excluded from this pull request.
Testing
provision vultr mgmt with branch
--gitops-template-branch vultr-physicaland for pro api use this branch (Link) and for pro ui (Link)