Skip to content

feat: vultr physical support#848

Merged
jokestax merged 16 commits intomainfrom
vultr-physical
Jan 13, 2025
Merged

feat: vultr physical support#848
jokestax merged 16 commits intomainfrom
vultr-physical

Conversation

@jokestax
Copy link
Copy Markdown
Contributor

@jokestax jokestax commented Dec 30, 2024

Description

Implemented functionality to provision physical clusters within the Vultr environment. This update includes the addition of a GPU-cluster template, although the integration of the NVIDIA operator is excluded from this pull request.

Testing

provision vultr mgmt with branch --gitops-template-branch vultr-physical and for pro api use this branch (Link) and for pro ui (Link)

@jokestax jokestax requested a review from mrsimonemms January 7, 2025 09:07
@mrsimonemms
Copy link
Copy Markdown
Contributor

Update on the testing note - to update the Kubefirst Pro API/UI, use the targetRevision to 2.7.10-rc33 in registry/clusters/sje-vultr/components/kubefirst/console.yaml

Copy link
Copy Markdown
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To test this I:

  • installed Vultr
  • created a physical cluster from the console
  • installed Flappy KRay
  • achieved a record high score (11 - yes, I'm rubbish at it)
  • deleted the physical cluster from the console
  • done a small dance

There are a couple of nits that I'd like fixing in the code please:

  • couple of files without a trailing whitespace
  • please also run terraform format on the changed files

I'm planning on adding a CI job to check these linting issues in the near future.

@jokestax
Copy link
Copy Markdown
Contributor Author

jokestax commented Jan 9, 2025

Hi @mrsimonemms ,i did use terraform fmt,i didnt see any changes 😅

@jokestax jokestax requested a review from mrsimonemms January 9, 2025 17:40
@mrsimonemms
Copy link
Copy Markdown
Contributor

Did you do it at the root of the project, or for the specific files changed (ie, terraform fmt /path/to/file?)

There are definitely some formatting changes that I'd expect to see.

@jokestax
Copy link
Copy Markdown
Contributor Author

Hi @mrsimonemms ,when i formatted indiviual file it worked,i pushed the changes and even added gitlab support as well

@jokestax jokestax self-assigned this Jan 13, 2025
@jokestax jokestax added the enhancement New feature or request label Jan 13, 2025
@mrsimonemms
Copy link
Copy Markdown
Contributor

mrsimonemms commented Jan 13, 2025

It probably would have been better to keep GitHub and GitLab changes in separate PRs as this is now a very big PR.

Can you remove the GitLab commit and put it in a separate PR please?

@jokestax
Copy link
Copy Markdown
Contributor Author

reverted changes @mrsimonemms 👍

Copy link
Copy Markdown
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stylistic nits.

Are you using EditorConfig in your IDE? This will automate most of these away for you.

@jokestax jokestax requested a review from mrsimonemms January 13, 2025 12:41
Copy link
Copy Markdown
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@jokestax
Copy link
Copy Markdown
Contributor Author

thank you Simon ❤️

@jokestax jokestax merged commit 85f0fd4 into main Jan 13, 2025
@jokestax jokestax deleted the vultr-physical branch January 13, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants