fix: correct typo in vault/secrets.tf for gitlab deployments#804
Merged
fharper merged 1 commit intokonstructio:mainfrom Jan 6, 2025
Merged
fix: correct typo in vault/secrets.tf for gitlab deployments#804fharper merged 1 commit intokonstructio:mainfrom
fharper merged 1 commit intokonstructio:mainfrom
Conversation
patrickdappollonio
approved these changes
Sep 23, 2024
patrickdappollonio
left a comment
patrickdappollonio
left a comment
There was a problem hiding this comment.
Thank you so much for catching this!
Contributor
|
@dan-os can you ping me on our Slack community, I'm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I caught a small typo in the
/deploy-tokens/container-registry-authvault secret for all gitlab deployments. I discovered this while troubleshooting some authentication issues (although, this typo turned out to be unrelated to that). Thanks for all your work!Related Issue(s)
N/A
How to test
N/A