feat: add auto bump version ops template#695
Conversation
bbeba44 to
d0cbfcc
Compare
|
Thanks for this PR @DrummyFloyd . Will check with the engineering team what auto updating these dependencies would mean for kubefirst. |
|
Thank for the review , do not hesitate if you want more info ! |
|
Sorry, this fall under the desk. I asked the engineering team to give it a closer look again. |
|
Thanks @DrummyFloyd |
|
@DrummyFloyd can you sign your commit please 😅 |
Dumb question , but how can I sign my commit with your merged stuff ? ^^ |
|
@DrummyFloyd oh yeah, AFAIK, it's a PITA to rebase for signing with newer commits... I should have seen it before (I had to merge |
DW , will create this PR later. Or if you want to merge quickly this just took the diff and do the PR , don't care if it's my name appears or not ^^ |
|
It's not that difficult to sign existing commits. I've not done it for a while so I can't remember exactly how it's done, but this looks about right - https://superuser.com/questions/397149/can-you-gpg-sign-old-commits |
|
I'll have a look and see if I can do it - I think it'll be a joint commit then. |
Signed-off-by: DrummyFloyd <[email protected]>
39232bd to
61bd26c
Compare
|
Yes, I also rebased the commits rather than rebased, just because I hate merge commits. |
Yeah, it's what I do for my own commits, but I thought it was a PITA to do that when there are multiple commits after that aren't yours. Thanks anyway, and thanks again @DrummyFloyd ! |
I hate merge commit for that I forgot the '--no-edit' that's why it change some stuff after on my side .. Anyway thank you :) |
|
We'll aim to get your next PR in under a year 😆 Thanks for everything. |
based on this comment from slack
https://kubefirst.slack.com/archives/C03U34WJ7FW/p1703867034753859
i though to have have such automated mechanism, would be a game changer for the ops template
that's why i came with a quick implementaiton of
renovatethis bot will create PR for all argocd APP:kustomization and terraform .
i make a the default setting for the AUTOMERGE( but can be easily change in the JSON file , we can discuss about it if you want) (all config options are here
for me you can allow ALL to an AUTOmerge (in FF mode ) (fastforward merge lover here) .
because you provide a template on a one time based . so no risk to break anything on update in customer side. ( but maybe i'm wrong about it)
meanwhile,
you have to enable install the app trhough the github portal => https://github.com/apps/renovate
then i advise you to make firsly a silent config, like this you can check what is achieve by renovate.
then allow only repository where a config file is present.
more info about renovate here
edit: you can check created MR on my fork https://github.com/DrummyFloyd/gitops-template/pulls?q=is%3Apr+is%3Aclosed
to check how it's looked