Make Infinity and NaN parsable, make isInfinite(NaN) return false#1160
Merged
konsoletyper merged 4 commits intokonsoletyper:masterfrom Feb 24, 2026
Merged
Make Infinity and NaN parsable, make isInfinite(NaN) return false#1160konsoletyper merged 4 commits intokonsoletyper:masterfrom
konsoletyper merged 4 commits intokonsoletyper:masterfrom
Conversation
| } | ||
|
|
||
| @Test | ||
| @SkipPlatform({ TestPlatform.WASI, TestPlatform.WEBASSEMBLY, TestPlatform.WEBASSEMBLY_GC, TestPlatform.C }) |
Owner
There was a problem hiding this comment.
What prevents you from implementing this on WasmGC backend?
| public static native boolean isNaN(double v); | ||
|
|
||
| @JSBody(params = "v", script = "return !isFinite(v);") | ||
| @JSBody(params = "v", script = "return (!isFinite(v) && !isNaN(v));") |
Owner
There was a problem hiding this comment.
I think the most straightforward implementation here would be just turn this method into non-native and call isNaN and isFinite from Java side. This will solve the issue with other backends
…rns false on all backends
lll69
changed the title
Owner
|
Please, fix checkstyle errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Infinity and NaN parsable, and make isInfinite(NaN) return false in JS, fixes issue #1156 on JS and issue #1154