Skip to content

Implement Safari fallback for string builtins #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bertung wants to merge 1 commit into from
+6 −1
Closed

Implement Safari fallback for string builtins #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/src/main/js/wasm-gc-runtime/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,11 @@ async function compileModule(src, isNodeJs) {
}

function hasStringBuiltins() {
// Ensure Safari fallback for string builtins
if (/.*version\/(\d+\.\d+).*/.exec(navigator.userAgent.toLowerCase()) !== null) {
if (parseFloat(RegExp.$1) < 28) return null;
}

if (stringBuiltinsCache === null) {
/*
(module
Expand Down Expand Up @@ -931,4 +936,4 @@ async function fetchExternalDebugInfo(path, debugInfoLocation, options, isNodeJs
}

return new Int8Array(buffer);
}
}
Loading