refactor: Implement lazy loading for street network in MLYMetadata#142
Merged
koito19960406 merged 2 commits intomainfrom Feb 19, 2026
Merged
refactor: Implement lazy loading for street network in MLYMetadata#142koito19960406 merged 2 commits intomainfrom
koito19960406 merged 2 commits intomainfrom
Conversation
This commit refactors the MLYMetadata class to load the street network data lazily, improving initialization efficiency. The `_ensure_street_network` method is introduced to handle the loading and preparation of the street network only when needed. Additionally, the test fixture is updated to pre-warm the street network for valid test cases. ### Key Changes - Removed immediate loading of street network data during initialization. - Added `_ensure_street_network` method for lazy loading. - Updated test fixture to call `_ensure_street_network` for caching. These changes enhance performance and resource management in the MLYMetadata class.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 11. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This commit refactors the DataFrame creation process in the MLYMetadata class by consolidating the initialization of the `sn_pl` DataFrame into a single line. This change enhances code readability and maintains the same functionality. ### Key Changes - Combined multiple lines into a single line for creating the `sn_pl` DataFrame. This adjustment contributes to cleaner and more maintainable code in the MLYMetadata class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the MLYMetadata class to load the street network data lazily, improving initialization efficiency. The
_ensure_street_networkmethod is introduced to handle the loading and preparation of the street network only when needed. Additionally, the test fixture is updated to pre-warm the street network for valid test cases.Key Changes
_ensure_street_networkmethod for lazy loading._ensure_street_networkfor caching.These changes enhance performance and resource management in the MLYMetadata class.