Skip to content

patch: fix estimator kwargs in signature #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2024
Merged

patch: fix estimator kwargs in signature #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
999bb16
refactor all **kwargs into kwargs
FBruzzesi Jul 28, 2024
9afe9ac
refactor tests
FBruzzesi Jul 28, 2024
372f7c3
rerun meta-models
FBruzzesi Jul 28, 2024
ede95e2
print
FBruzzesi Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions docs/_scripts/meta-models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def plot_model(model):
("datagrab", FeatureUnion([
("discrete", Pipeline([
("grab", ColumnSelector("diet")),
("encode", OneHotEncoder(categories="auto", sparse=False))
("encode", OneHotEncoder(categories="auto"))
Copy link
Collaborator Author

@FBruzzesi FBruzzesi Jul 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kwarg name changed in one of the latest versions, unrelated to PR

])),
("continuous", Pipeline([
("grab", ColumnSelector("time")),
Expand Down Expand Up @@ -265,8 +265,15 @@ def plot_model(model):
mod1 = (GroupedPredictor(DummyRegressor(), groups=["m"])
.fit(df[["m"]], df["yt"]))

mod2 = (GroupedPredictor(DecayEstimator(DummyRegressor(), decay_func="exponential", decay_rate=0.9), groups=["m"])
.fit(df[["index", "m"]], df["yt"]))
mod2 = (GroupedPredictor(
estimator=DecayEstimator(
model=DummyRegressor(),
decay_func="exponential",
decay_kwargs={"decay_rate": 0.9}
),
groups=["m"]
).fit(df[["index", "m"]], df["yt"])
)

plt.figure(figsize=(12, 3))
plt.plot(df["yt"], alpha=0.5);
Expand Down Expand Up @@ -494,12 +501,16 @@ def false_negatives(mod, x, y):
from sklearn.linear_model import LogisticRegression
from sklego.meta import OrdinalClassifier

ord_clf = OrdinalClassifier(LogisticRegression(), n_jobs=-1, use_calibration=False)
_ = ord_clf.fit(X, y)
ord_clf.predict_proba(X[0])
ord_clf = OrdinalClassifier(
LogisticRegression(),
n_jobs=-1,
use_calibration=False,
).fit(X, y)

ord_clf.predict_proba(X[:1])
# --8<-- [end:ordinal-classifier]

print(ord_clf.predict_proba(X[0]))
print(ord_clf.predict_proba(X[:1]))

# --8<-- [start:ordinal-classifier-with-calibration]
from sklearn.calibration import CalibratedClassifierCV
Expand Down
Binary file modified docs/_static/meta-models/baseline-model.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading