patch: ZeroInflatedRegressor fix training indices
#666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
May 11, 2024
| self.classifier_.fit(X, y != 0, sample_weight=sample_weight) | ||
| else: | ||
| logging.warning("Classifier ignores sample_weight.") | ||
| self.classifier_.fit(X, y != 0) |
There was a problem hiding this comment.
Just as a side note after taking a look at the internals: as classifier_ is supposed to classify zeros, wouldn't make sense to fit on y==0? If so, that's a total of 3 lines that need changes. Not big deal anyway
koaning
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue reported in #664 is very reasonable. I tried to take a look at when
ZeroInflatedRegressorwas introduced in #442, but I couldn't find any related discussion on such choice.Fix #664
Type of change