Skip to content

Conversation

@FBruzzesi
Copy link
Collaborator

Description

Adds support for python 3.12

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines (flake8)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (also to the readme.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests to check whether the new feature adheres to the sklearn convention
  • New and existing unit tests pass locally with my changes

"pandas>=1.1.5",
"scikit-learn>=1.0",
"importlib-metadata >= 1.0; python_version < '3.8'",
"importlib-resources; python_version < '3.9'",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

importlib.resources.files is new in 3.9, importlib-resources is the backport

@koaning
Copy link
Owner

koaning commented Mar 19, 2024

Maybe add a version bump so we can release a patch right away? Other than that, LGTM!

Copy link
Owner

@koaning koaning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll make the release right away, but lets not forget to market/tweet about it later this week.

@koaning koaning merged commit 5f6c3e8 into koaning:main Mar 19, 2024
@FBruzzesi FBruzzesi deleted the feature/support-312 branch March 19, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants