Revert "drop -m flag" to fix empty SBOM generation in v0.18.0#1514
Merged
imjasonh merged 2 commits intoko-build:mainfrom May 16, 2025
Merged
Revert "drop -m flag" to fix empty SBOM generation in v0.18.0#1514imjasonh merged 2 commits intoko-build:mainfrom
v0.18.0#1514imjasonh merged 2 commits intoko-build:mainfrom
Conversation
This reverts commit 3f2f5a5.
v0.18.0
Contributor
Author
|
Oh, when an invalid non-Go binary file is passed to |
imjasonh
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3f2f5a5.
Since
ko v0.18.0, mostly empty SBOMs have been generated. While investigating the cause of this, I noticed that the-mflag was removed fromgo version -mby commit 3f2f5a5. If the-mflag is not specified, module versions are not outputted, resulting in the generation of SBOMs that do not include module information.This PR resolves this issue by reverting the commit that removed the
-mflag. As far as I tested, the output ofgo version -mdid not differ between Go 1.23 and Go 1.24.0.