Merged
Conversation
gabe565
changed the title
Member
|
can you please rebase? |
Contributor
Author
|
@cpanato I tried to rebase, and it seems that this PR is up to date. Do you need me to |
Member
|
@gabe565 let me try here |
Member
|
ahh i see the errors, that is not caused by this PR, will check soon thanks! |
Member
|
The build failure is unrelated, I'm just going to force merge past it. The change itself looks good, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I just discovered ko, and noticed the docs site doesn't have a dark mode. Mkdocs Material now supports auto light/dark mode, so I thought I'd enable it. The only other thing I changed was adding a dark-mode CNCF logo, which gets served depending on which theme is chosen.