Skip to content

debug: separate target and delve parameters#1368

Merged
cpanato merged 1 commit intoko-build:mainfrom
zregvart:pr/dlv-param-separation
Oct 8, 2024
Merged

debug: separate target and delve parameters#1368
cpanato merged 1 commit intoko-build:mainfrom
zregvart:pr/dlv-param-separation

Conversation

@zregvart
Copy link
Contributor

Adds the -- separator parameter so delve doesn't try to parse any command line parameters intended for the target binary.

Copy link

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please can we move forward with this? 🙏

@cpanato
Copy link
Member

cpanato commented Sep 25, 2024

need a rebase

@phisco
Copy link

phisco commented Sep 25, 2024

@zregvart it would be awesome if you could rebase this 🙏

@zregvart zregvart force-pushed the pr/dlv-param-separation branch from b3a2449 to 0cda1a1 Compare September 25, 2024 14:40
Adds the `--` separator parameter so delve doesn't try to parse any
command line parameters intended for the target binary.
@zregvart zregvart force-pushed the pr/dlv-param-separation branch from 0cda1a1 to dcd4c9b Compare September 26, 2024 09:42
Copy link

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @zregvart! CC @cpanato 🙏

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato merged commit 08c82b9 into ko-build:main Oct 8, 2024
@zregvart zregvart deleted the pr/dlv-param-separation branch October 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants