Add support for setting POSIX capabilities on the binary generated by Go

docs/reference/ko_apply.md

@@ -47,6 +47,7 @@ ko apply -f FILENAME [flags]
 ```
       --bare                     Whether to just use KO_DOCKER_REPO without additional context (may not work properly with --tags).
   -B, --base-import-paths        Whether to use the base path without MD5 hash after KO_DOCKER_REPO (may not work properly with --tags).
+      --cap-add strings          Which POSIX capabilities to set on the binary. Eg. CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER
       --disable-optimizations    Disable optimizations when building Go code. Useful when you want to interactively debug the created container.
   -f, --filename strings         Filename, directory, or URL to files to use to create the resource
   -h, --help                     help for apply

docs/reference/ko_build.md

@@ -44,6 +44,7 @@ ko build IMPORTPATH... [flags]
 ```
       --bare                     Whether to just use KO_DOCKER_REPO without additional context (may not work properly with --tags).
   -B, --base-import-paths        Whether to use the base path without MD5 hash after KO_DOCKER_REPO (may not work properly with --tags).
+      --cap-add strings          Which POSIX capabilities to set on the binary. Eg. CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER
       --disable-optimizations    Disable optimizations when building Go code. Useful when you want to interactively debug the created container.
   -h, --help                     help for build
       --image-label strings      Which labels (key=value) to add to the image.

docs/reference/ko_create.md

@@ -47,6 +47,7 @@ ko create -f FILENAME [flags]
 ```
       --bare                     Whether to just use KO_DOCKER_REPO without additional context (may not work properly with --tags).
   -B, --base-import-paths        Whether to use the base path without MD5 hash after KO_DOCKER_REPO (may not work properly with --tags).
+      --cap-add strings          Which POSIX capabilities to set on the binary. Eg. CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER
       --disable-optimizations    Disable optimizations when building Go code. Useful when you want to interactively debug the created container.
   -f, --filename strings         Filename, directory, or URL to files to use to create the resource
   -h, --help                     help for create

docs/reference/ko_resolve.md

@@ -40,6 +40,7 @@ ko resolve -f FILENAME [flags]
 ```
       --bare                     Whether to just use KO_DOCKER_REPO without additional context (may not work properly with --tags).
   -B, --base-import-paths        Whether to use the base path without MD5 hash after KO_DOCKER_REPO (may not work properly with --tags).
+      --cap-add strings          Which POSIX capabilities to set on the binary. Eg. CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER
       --disable-optimizations    Disable optimizations when building Go code. Useful when you want to interactively debug the created container.
   -f, --filename strings         Filename, directory, or URL to files to use to create the resource
   -h, --help                     help for resolve

docs/reference/ko_run.md

@@ -32,6 +32,7 @@ ko run IMPORTPATH [flags]
 ```
       --bare                     Whether to just use KO_DOCKER_REPO without additional context (may not work properly with --tags).
   -B, --base-import-paths        Whether to use the base path without MD5 hash after KO_DOCKER_REPO (may not work properly with --tags).
+      --cap-add strings          Which POSIX capabilities to set on the binary. Eg. CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER
       --disable-optimizations    Disable optimizations when building Go code. Useful when you want to interactively debug the created container.
   -h, --help                     help for run
       --image-label strings      Which labels (key=value) to add to the image.

integration_test.sh

@@ -92,6 +92,7 @@ fi
 echo "7. On outside the module should fail."
 pushd .. || exit 1
 GO111MODULE=on ./ko/ko build --local github.com/go-training/helloworld && exit 1
+echo "Test PASSED"
 popd || exit 1
 
 echo "8. On outside with build config specifying the test module builds."
@@ -110,6 +111,18 @@ for app in foo bar ; do
 done
 popd || exit 1
 
+echo "9. Auto inside the module without vendoring & run with requesteed capabilities should output TEST"
+RESULT="$(GO111MODULE=auto GOFLAGS="" ./ko build --cap-add CAP_IPC_LOCK --local github.com/go-training/helloworld | grep "$FILTER" | xargs -I% docker run --cap-add CAP_IPC_LOCK %)"
+if [[ "$RESULT" != *"TEST"* ]]; then
+  echo "Test FAILED. Saw $RESULT" && exit 1
+else
+  echo "Test PASSED"
+fi
+
+echo "10. Auto inside the module without vendoring & run with too little capabilities should fail"
+(GO111MODULE=auto GOFLAGS="" ./ko build --cap-add CAP_CHOWN --local github.com/go-training/helloworld | grep "$FILTER" | xargs -I% docker run --cap-drop CAP_CHOWN %) && exit 1
+echo "Test PASSED"
+
 popd || exit 1
 popd || exit 1
 

pkg/build/gobuild.go

@@ -18,6 +18,7 @@ import (
 	"archive/tar"
 	"bytes"
 	"context"
+	"encoding/binary"
 	"errors"
 	"fmt"
 	gb "go/build"
@@ -81,6 +82,7 @@ type gobuild struct {
 	disableOptimizations bool
 	trimpath             bool
 	buildConfigs         map[string]Config
+	capabilities         []Cap
 	platformMatcher      *platformMatcher
 	dir                  string
 	labels               map[string]string
@@ -103,6 +105,7 @@ type gobuildOpener struct {
 	disableOptimizations bool
 	trimpath             bool
 	buildConfigs         map[string]Config
+	capabilities         []Cap
 	platforms            []string
 	labels               map[string]string
 	dir                  string
@@ -131,6 +134,7 @@ func (gbo *gobuildOpener) Open() (Interface, error) {
 		disableOptimizations: gbo.disableOptimizations,
 		trimpath:             gbo.trimpath,
 		buildConfigs:         gbo.buildConfigs,
+		capabilities:         gbo.capabilities,
 		labels:               gbo.labels,
 		dir:                  gbo.dir,
 		platformMatcher:      matcher,
@@ -488,7 +492,7 @@ func appFilename(importpath string) string {
 // owner: BUILTIN/Users group: BUILTIN/Users ($sddlValue="O:BUG:BU")
 const userOwnerAndGroupSID = "AQAAgBQAAAAkAAAAAAAAAAAAAAABAgAAAAAABSAAAAAhAgAAAQIAAAAAAAUgAAAAIQIAAA=="
 
-func tarBinary(name, binary string, platform *v1.Platform) (*bytes.Buffer, error) {
+func tarBinary(name, binary string, platform *v1.Platform, caps []Cap) (*bytes.Buffer, error) {
 	buf := bytes.NewBuffer(nil)
 	tw := tar.NewWriter(buf)
 	defer tw.Close()
@@ -543,6 +547,12 @@ func tarBinary(name, binary string, platform *v1.Platform) (*bytes.Buffer, error
 		header.PAXRecords = map[string]string{
 			"MSWINDOWS.rawsd": userOwnerAndGroupSID,
 		}
+	} else if len(caps) > 0 {
+		// see: https://github.com/testwill/moby/blob/master/pkg/archive/archive.go#L503-L504
+		header.PAXRecords = map[string]string{
+			"SCHILY.xattr.security.capability": string(capabilityValue(caps)),
+		}
+		header.Format = tar.FormatPAX
 	}
 	// write the header to the tarball archive
 	if err := tw.WriteHeader(header); err != nil {
@@ -556,6 +566,40 @@ func tarBinary(name, binary string, platform *v1.Platform) (*bytes.Buffer, error
 	return buf, nil
 }
 
+func capabilityValue(caps []Cap) []byte {
+	vfsCapVer2 := uint32(0x02000000)
+	vfsCapFlageffective := uint32(0x000001)
+
+	// This is the full encoded capbility set for CAP_IPC_LOCK
+	// 02 00 00 01 (version 2, effective)
+	// XX XX XX XX (permitted_v1)
+	// 00 00 00 00 (inheritable_v1: 0)
+	// XX XX XX XX (permitted_v2)
+	// 00 00 00 00 (inheritable_v2: 0)
+
+	permitted_v1 := uint32(0)
+	inheritable_v1 := uint32(0)
+	permitted_v2 := uint32(0)
+	inheritable_v2 := uint32(0)
+
+	for _, cap := range caps {
+		if cap > 32 {
+			permitted_v2 |= 1 << (cap - 32)
+		} else {
+			permitted_v1 |= 1 << cap
+		}
+	}
+
+	capability := make([]byte, 0, 20)
+	capability = binary.LittleEndian.AppendUint32(capability, vfsCapVer2|vfsCapFlageffective)
+	capability = binary.LittleEndian.AppendUint32(capability, permitted_v1)
+	capability = binary.LittleEndian.AppendUint32(capability, inheritable_v1)
+	capability = binary.LittleEndian.AppendUint32(capability, permitted_v2)
+	capability = binary.LittleEndian.AppendUint32(capability, inheritable_v2)
+
+	return capability
+}
+
 func (g *gobuild) kodataPath(ref reference) (string, error) {
 	dir := filepath.Clean(g.dir)
 	if dir == "." {
@@ -865,7 +909,7 @@ func (g *gobuild) buildOne(ctx context.Context, refStr string, base v1.Image, pl
 	appPath := path.Join(appDir, appFileName)
 
 	miss := func() (v1.Layer, error) {
-		return buildLayer(appPath, file, platform, layerMediaType)
+		return buildLayer(appPath, file, platform, layerMediaType, g.capabilities)
 	}
 
 	binaryLayer, err := g.cache.get(ctx, file, miss)
@@ -948,9 +992,9 @@ func (g *gobuild) buildOne(ctx context.Context, refStr string, base v1.Image, pl
 	return si, nil
 }
 
-func buildLayer(appPath, file string, platform *v1.Platform, layerMediaType types.MediaType) (v1.Layer, error) {
+func buildLayer(appPath, file string, platform *v1.Platform, layerMediaType types.MediaType, caps []Cap) (v1.Layer, error) {
 	// Construct a tarball with the binary and produce a layer.
-	binaryLayerBuf, err := tarBinary(appPath, file, platform)
+	binaryLayerBuf, err := tarBinary(appPath, file, platform, caps)
 	if err != nil {
 		return nil, fmt.Errorf("tarring binary: %w", err)
 	}

pkg/build/options.go

@@ -177,3 +177,11 @@ func WithSBOMDir(dir string) Option {
 		return nil
 	}
 }
+
+// WithPOSIXCapabilities is a functional option for overriding the POSIX capabilities encoded in the binary file.
+func WithPOSIXCapabilities(capabilities []Cap) Option {
+	return func(gbo *gobuildOpener) error {
+		gbo.capabilities = capabilities
+		return nil
+	}
+}