-
Notifications
You must be signed in to change notification settings - Fork 2
Fix: Complete DevDesk to ZapDesk rebrand #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update all references from DevDesk to ZapDesk throughout the codebase: - Regenerated package-lock.json with correct package name - Updated .env.example with ZapDesk branding and generic placeholders - Updated all documentation files (DEPLOYMENT, EMAIL_SETUP, SETUP, etc.) - Updated test files to check for ZapDesk branding - Updated scripts and public assets (og-image.svg, generate-logo.js) - Updated GitHub issue templates - Removed hardcoded email addresses per security guidelines All quality checks pass (typecheck, lint, format). Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to complete the rebranding from DevDesk to ZapDesk as requested in issue #204. The changes update branding references across configuration files, documentation, tests, scripts, and assets.
Changes:
- Updated package configuration to use "zapdesk" package name
- Replaced DevDesk with ZapDesk across all documentation files (6 .adoc files)
- Updated test assertions to check for "ZapDesk" branding instead of "DevDesk"
- Modified environment configuration, scripts, and assets with new branding
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package-lock.json | Updated package name from "devdesk" to "zapdesk" |
| .env.example | Updated APP_NAME, SMTP_FROM_NAME to ZapDesk and replaced hardcoded emails with placeholders |
| tests/auth.spec.ts | Updated test to check for "ZapDesk" branding |
| tests/navigation.spec.ts | Updated tests to verify "ZapDesk" in page title and branding |
| scripts/generate-logo.js | Updated comments to reference ZapDesk (but logo implementation still incomplete) |
| scripts/README.md | Updated all DevDesk references to ZapDesk |
| public/og-image.svg | Updated text from "Dev" to "Zap" in the OG image |
| docs/DEPLOYMENT.adoc | Updated all DevDesk references, Azure resource names, and domain examples |
| docs/EMAIL_SETUP.adoc | Updated branding and replaced hardcoded emails with placeholders |
| docs/SETUP.adoc | Updated branding and Azure resource names (one incomplete reference found) |
| docs/SOLUTION_DESIGN.adoc | Updated all references and table headers |
| docs/TESTING.adoc | Updated all DevDesk references to ZapDesk |
| docs/TROUBLESHOOTING.adoc | Updated branding, Azure resource names, and GitHub URLs |
| .github/ISSUES/responsive-design-dashboard.md | Updated issue template with ZapDesk branding |
| .claude/settings.local.json | New local configuration file (should not be committed) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f2ebd2b to
5229742
Compare
- Update generate-logo.js description to reference lightning bolt icon - Change SVG text from "Dev" to "Zap" in both dark and light logos - Fix CNAME record in SETUP.adoc from devdesk to zapdesk - Remove .claude/settings.local.json from repo (local config) - Add .claude/settings.local.json to .gitignore Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Use getByRole for more specific locators - Update home page test to check landing page instead of redirect - Remove obsolete /customers route and API tests - Rename organizations test to projects Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
@BenGWeeks all code review comments are fixed now. @EdiWeeks this is read to test |
EdiWeeks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Regenerated lockfile to reflect the package name change in package.json. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Summary
Completes the rebrand from DevDesk to ZapDesk as requested in #204.
Changes Made
Package Configuration
package-lock.jsonwith correct package name "zapdesk"Environment Configuration
.env.examplewith ZapDesk brandingAPP_NAMEto "ZapDesk"SMTP_FROM_NAMEto "ZapDesk Support"Documentation (docs/*.adoc)
Test Files
tests/auth.spec.tsto check for "ZapDesk" brandingtests/navigation.spec.tsto check for "ZapDesk" in titleScripts & Assets
scripts/generate-logo.jscomments and referencesscripts/README.mdwith ZapDesk referencespublic/og-image.svgto display "ZapDesk" textGitHub Templates
.github/ISSUES/responsive-design-dashboard.mdQuality Checks
All checks pass successfully:
Testing
Security
Related Issue
Closes #204
🤖 Generated with Claude Code