Fix Teams toolbar icon visibility in dark mode

[BenGWeeks]

Summary

• Updated outline.png icon from black to white with transparent background
• Previously the black icon was invisible against the dark theme toolbar background
• White icon with transparent background works correctly in both light and dark modes

Test plan

• Install updated Teams app manifest
• Verify icon is visible in light mode
• Verify icon is visible in dark mode
• Test in Teams meeting toolbar

Fixes #55

🤖 Generated with Claude Code

[claude]

Pull Request Review - PR #56

Summary

This PR updates the Teams toolbar icon (outline.png) from black to white with a transparent background to fix visibility issues in dark mode. The change directly addresses issue #55.

---

✅ Positive Aspects

1. Clear Problem-Solution: The PR correctly identifies and fixes the dark mode visibility issue
2. Follows Teams Guidelines: Using a white icon on transparent background is the standard approach for Teams outline icons that need to work in both light and dark modes
3. Good Documentation: PR description includes a clear test plan and references the related issue
4. Minimal Change: Binary file replacement is the appropriate solution - no code changes needed

---

🔍 Review Findings

Code Quality: ✅ PASS

• Appropriate file type (PNG with transparency)
• File size is reasonable (2.4K - within Teams guidelines)
• Located in correct directory (bot/teams-manifest/)

Best Practices: ✅ PASS

• Follows Microsoft Teams icon conventions for outline icons
• Transparent background allows Teams to handle theme adaptation
• White icon color is standard for toolbar visibility

Security: ✅ PASS

• Binary image file poses no security concerns
• No code execution or injection risks

Performance: ✅ PASS

• File size is appropriate (2.4K)
• PNG format is correct for Teams icons

---

📝 Recommendations

Minor Suggestions:

1. Icon Size Verification - Microsoft Teams requires outline icons to be 32x32 pixels. Consider verifying the dimensions:

   file bot/teams-manifest/outline.png
   # Should show: PNG image data, 32 x 32

2. Test Plan Completion - Before merging, ensure all test plan checkboxes are completed:

   • Install updated Teams app manifest
   • Verify icon is visible in light mode
   • Verify icon is visible in dark mode
   • Test in Teams meeting toolbar

3. Consider Adding color.png to Review - If color.png (the 96x96 color icon) has similar visibility issues, it may also need updating. The current one might be fine, but worth checking.

4. Documentation Update - Consider adding a note to the README or a new bot/teams-manifest/README.md about icon requirements:

   • outline.png: 32x32px, white on transparent, for toolbar
   • color.png: 96x96px, full color, for app catalog

---

🎯 Verdict: APPROVE ✅

This is a straightforward, well-documented fix that addresses a real usability issue. The change follows Microsoft Teams best practices and poses no risks.

Recommendation: Approve and merge once the test plan checklist is completed.

---

📚 Reference

• Related Issue: Teams meeting bar icon not visible in dark mode #55
• Microsoft Teams Icon Guidelines: App icons documentation
• Manifest file: bot/teams-manifest/manifest.json:20-22

[github-actions]

Test Results

• Lint: success
• Build: success
• Unit Tests: success
• Bicep Validation: skipped