Fix mt-broker-ingress auth to work with structured event too#8710
Conversation
knative-prow
bot
added
the
area/test-and-release
knative-prow
bot
added
approved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8710 +/- ##
==========================================
+ Coverage 51.59% 51.61% +0.01%
==========================================
Files 401 401
Lines 25431 25459 +28
==========================================
+ Hits 13122 13141 +19
- Misses 11507 11511 +4
- Partials 802 807 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| // CopyRequest makes a copy of the http request which can be consumed as needed, leaving the original request | ||
| // able to be consumed as well. | ||
| func CopyRequest(req *http.Request) (*http.Request, error) { |
|
https://github.com/knative/eventing/blob/main/pkg/channel/event_receiver.go#L285-L319 looks like a similar problem. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test upgrade-tests |
|
/cherry-pick release-1.19 |
|
/cherry-pick release-1.18 |
|
@creydr: new pull request created: #8713 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@creydr: new pull request created: #8714 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…#8710) * Fix mt-broker-ingress auth to work with structured event too * Fix channel receiver auth to work with structured event too * Add unit test
…#8710) * Fix mt-broker-ingress auth to work with structured event too * Fix channel receiver auth to work with structured event too * Add unit test
…#8710) * Fix mt-broker-ingress auth to work with structured event too * Fix channel receiver auth to work with structured event too * Add unit test
…#8710) * Fix mt-broker-ingress auth to work with structured event too * Fix channel receiver auth to work with structured event too * Add unit test
…#8710) (#1683) * Fix mt-broker-ingress auth to work with structured event too * Fix channel receiver auth to work with structured event too * Add unit test Co-authored-by: Christoph Stäbler <[email protected]>
5 participants
Fixes #8707