-
Notifications
You must be signed in to change notification settings - Fork 7
Feat/happy path(claimer) in validator-cli #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 18 commits
ad77cf4
371e8d0
7173b75
240f5f7
a25b473
cfa2e02
105a50a
edce69c
3f78877
4eb9b3c
06220dd
84ab53f
5b0740a
2e67ae2
af153e1
2316c21
88deca7
bedb92c
d85dd2d
3b3d905
f1bb940
54fbed2
66c1fc6
410a068
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,234 @@ | ||
| import { ethers } from "ethers"; | ||
| import { checkAndClaim, CheckAndClaimParams } from "./claimer"; | ||
| import { ClaimHonestState } from "../utils/claim"; | ||
| import { Network } from "../consts/bridgeRoutes"; | ||
|
|
||
| describe("claimer", () => { | ||
| const NETWORK = Network.DEVNET; | ||
| let veaOutbox: any; | ||
| let veaInbox: any; | ||
| let veaInboxProvider: any; | ||
| let veaOutboxProvider: any; | ||
| let emitter: any; | ||
| let mockClaim: any; | ||
| let mockGetLatestClaimedEpoch: any; | ||
| let mockGetTransactionHandler: any; | ||
| let mockDeps: CheckAndClaimParams; | ||
|
|
||
| let mockTransactionHandler: any; | ||
| const mockTransactions = { | ||
| claimTxn: "0x111", | ||
| withdrawClaimDepositTxn: "0x222", | ||
| startVerificationTxn: "0x333", | ||
| verifySnapshotTxn: "0x444", | ||
| devnetAdvanceStateTxn: "0x555", | ||
| }; | ||
| beforeEach(() => { | ||
| mockClaim = { | ||
| stateRoot: "0x1234", | ||
| claimer: "0xFa00D29d378EDC57AA1006946F0fc6230a5E3288", | ||
| timestampClaimed: 1234, | ||
| timestampVerification: 0, | ||
| blocknumberVerification: 0, | ||
| honest: 0, | ||
| challenger: ethers.ZeroAddress, | ||
| }; | ||
| veaInbox = { | ||
| snapshots: jest.fn().mockResolvedValue(mockClaim.stateRoot), | ||
| }; | ||
|
|
||
| veaOutbox = { | ||
| stateRoot: jest.fn().mockResolvedValue(mockClaim.stateRoot), | ||
| }; | ||
| veaOutboxProvider = { | ||
| getBlock: jest.fn().mockResolvedValue({ number: 0, timestamp: 110 }), | ||
| }; | ||
| emitter = { | ||
| emit: jest.fn(), | ||
| }; | ||
|
|
||
| mockGetLatestClaimedEpoch = jest.fn(); | ||
| mockGetTransactionHandler = jest.fn().mockReturnValue(function DummyTransactionHandler(params: any) { | ||
| // Return an object that matches our expected transaction handler. | ||
| return mockTransactionHandler; | ||
| }); | ||
| mockDeps = { | ||
| chainId: 0, | ||
| claim: mockClaim, | ||
| network: NETWORK, | ||
| epoch: 10, | ||
| epochPeriod: 10, | ||
| veaInbox, | ||
| veaInboxProvider, | ||
| veaOutboxProvider, | ||
| veaOutbox, | ||
| transactionHandler: null, | ||
| emitter, | ||
| fetchLatestClaimedEpoch: mockGetLatestClaimedEpoch, | ||
| now: 110000, // (epoch+ 1) * epochPeriod * 1000 for claimable epoch | ||
| }; | ||
|
|
||
| mockTransactionHandler = { | ||
| withdrawClaimDeposit: jest.fn().mockImplementation(() => { | ||
| mockTransactionHandler.transactions.withdrawClaimDepositTxn = mockTransactions.withdrawClaimDepositTxn; | ||
| return Promise.resolve(); | ||
| }), | ||
| makeClaim: jest.fn().mockImplementation(() => { | ||
| mockTransactionHandler.transactions.claimTxn = mockTransactions.claimTxn; | ||
| return Promise.resolve(); | ||
| }), | ||
| startVerification: jest.fn().mockImplementation(() => { | ||
| mockTransactionHandler.transactions.startVerificationTxn = mockTransactions.startVerificationTxn; | ||
| return Promise.resolve(); | ||
| }), | ||
| verifySnapshot: jest.fn().mockImplementation(() => { | ||
| mockTransactionHandler.transactions.verifySnapshotTxn = mockTransactions.verifySnapshotTxn; | ||
| return Promise.resolve(); | ||
| }), | ||
| transactions: { | ||
| claimTxn: "0x0", | ||
| withdrawClaimDepositTxn: "0x0", | ||
| startVerificationTxn: "0x0", | ||
| verifySnapshotTxn: "0x0", | ||
| }, | ||
| }; | ||
| }); | ||
| afterEach(() => { | ||
| jest.clearAllMocks(); | ||
| }); | ||
| describe("checkAndClaim", () => { | ||
| beforeEach(() => { | ||
| mockTransactionHandler = { | ||
| withdrawClaimDeposit: jest.fn().mockImplementation(() => { | ||
| mockTransactionHandler.transactions.withdrawClaimDepositTxn = mockTransactions.withdrawClaimDepositTxn; | ||
| return Promise.resolve(); | ||
| }), | ||
| makeClaim: jest.fn().mockImplementation(() => { | ||
| mockTransactionHandler.transactions.claimTxn = mockTransactions.claimTxn; | ||
| return Promise.resolve(); | ||
| }), | ||
| startVerification: jest.fn().mockImplementation(() => { | ||
| mockTransactionHandler.transactions.startVerificationTxn = mockTransactions.startVerificationTxn; | ||
| return Promise.resolve(); | ||
| }), | ||
| verifySnapshot: jest.fn().mockImplementation(() => { | ||
| mockTransactionHandler.transactions.verifySnapshotTxn = mockTransactions.verifySnapshotTxn; | ||
| return Promise.resolve(); | ||
| }), | ||
| devnetAdvanceState: jest.fn().mockImplementation(() => { | ||
| mockTransactionHandler.transactions.devnetAdvanceStateTxn = mockTransactions.devnetAdvanceStateTxn; | ||
| return Promise.resolve(); | ||
| }), | ||
| transactions: { | ||
| claimTxn: "0x0", | ||
| withdrawClaimDepositTxn: "0x0", | ||
| startVerificationTxn: "0x0", | ||
| verifySnapshotTxn: "0x0", | ||
| }, | ||
| }; | ||
| mockGetTransactionHandler = jest.fn().mockReturnValue(function DummyTransactionHandler(param: any) { | ||
| return mockTransactionHandler; | ||
| }); | ||
| mockDeps.fetchTransactionHandler = mockGetTransactionHandler; | ||
| }); | ||
| it("should return null if no claim is made for a passed epoch", async () => { | ||
| mockDeps.epoch = 7; // claimable epoch - 3 | ||
| mockDeps.claim = null; | ||
|
|
||
| mockDeps.fetchTransactionHandler = mockGetTransactionHandler; | ||
| const result = await checkAndClaim(mockDeps); | ||
| expect(result).toBeNull(); | ||
| }); | ||
| it("should return null if no snapshot is saved on the inbox for a claimable epoch", async () => { | ||
| veaInbox.snapshots = jest.fn().mockResolvedValue(ethers.ZeroHash); | ||
| mockGetLatestClaimedEpoch = jest.fn().mockResolvedValue({ | ||
| challenged: false, | ||
| stateroot: "0x1111", | ||
| }); | ||
| mockDeps.claim = null; | ||
| mockDeps.fetchLatestClaimedEpoch = mockGetLatestClaimedEpoch; | ||
| const result = await checkAndClaim(mockDeps); | ||
| expect(result).toBeNull(); | ||
| }); | ||
| it("should return null if there are no new messages in the inbox", async () => { | ||
| veaInbox.snapshots = jest.fn().mockResolvedValue(mockClaim.stateRoot); | ||
| mockGetLatestClaimedEpoch = jest.fn().mockResolvedValue({ | ||
| challenged: false, | ||
| stateroot: "0x1111", | ||
| }); | ||
| mockDeps.claim = null; | ||
| mockDeps.fetchLatestClaimedEpoch = mockGetLatestClaimedEpoch; | ||
| const result = await checkAndClaim(mockDeps); | ||
| expect(result).toBeNull(); | ||
| }); | ||
| describe("devnet", () => { | ||
| beforeEach(() => { | ||
| mockDeps.network = Network.DEVNET; | ||
| }); | ||
| it("should make a valid claim and advance state", async () => { | ||
| veaInbox.snapshots = jest.fn().mockResolvedValue("0x7890"); | ||
| mockGetLatestClaimedEpoch = jest.fn().mockResolvedValue({ | ||
| challenged: false, | ||
| stateroot: mockClaim.stateRoot, | ||
| }); | ||
| mockDeps.transactionHandler = mockTransactionHandler; | ||
| mockDeps.fetchLatestClaimedEpoch = mockGetLatestClaimedEpoch; | ||
| mockDeps.claim = null; | ||
| mockDeps.veaInbox = veaInbox; | ||
| const result = await checkAndClaim(mockDeps); | ||
| expect(result.transactions.devnetAdvanceStateTxn).toBe(mockTransactions.devnetAdvanceStateTxn); | ||
| }); | ||
| }); | ||
| describe("testnet", () => { | ||
| beforeEach(() => { | ||
| mockDeps.network = Network.TESTNET; | ||
| }); | ||
| it("should make a valid claim if no claim is made", async () => { | ||
| veaInbox.snapshots = jest.fn().mockResolvedValue("0x7890"); | ||
| mockGetLatestClaimedEpoch = jest.fn().mockResolvedValue({ | ||
| challenged: false, | ||
| stateroot: mockClaim.stateRoot, | ||
| }); | ||
| mockDeps.transactionHandler = mockTransactionHandler; | ||
| mockDeps.fetchLatestClaimedEpoch = mockGetLatestClaimedEpoch; | ||
| mockDeps.claim = null; | ||
| mockDeps.veaInbox = veaInbox; | ||
| const result = await checkAndClaim(mockDeps); | ||
| expect(result.transactions.claimTxn).toBe(mockTransactions.claimTxn); | ||
| }); | ||
| it("should make a valid claim if last claim was challenged", async () => { | ||
| veaInbox.snapshots = jest.fn().mockResolvedValue(mockClaim.stateRoot); | ||
| mockGetLatestClaimedEpoch = jest.fn().mockResolvedValue({ | ||
| challenged: true, | ||
| stateroot: mockClaim.stateRoot, | ||
| }); | ||
| mockDeps.transactionHandler = mockTransactionHandler; | ||
| mockDeps.fetchLatestClaimedEpoch = mockGetLatestClaimedEpoch; | ||
| mockDeps.claim = null; | ||
| mockDeps.veaInbox = veaInbox; | ||
| const result = await checkAndClaim(mockDeps); | ||
| expect(result.transactions.claimTxn).toEqual(mockTransactions.claimTxn); | ||
| }); | ||
| it("should withdraw claim deposit if claimer is honest", async () => { | ||
| mockDeps.transactionHandler = mockTransactionHandler; | ||
| mockClaim.honest = ClaimHonestState.CLAIMER; | ||
| const result = await checkAndClaim(mockDeps); | ||
| expect(result.transactions.withdrawClaimDepositTxn).toEqual(mockTransactions.withdrawClaimDepositTxn); | ||
| }); | ||
| it("should start verification if verification is not started", async () => { | ||
| mockDeps.transactionHandler = mockTransactionHandler; | ||
| mockClaim.honest = ClaimHonestState.NONE; | ||
| const result = await checkAndClaim(mockDeps); | ||
| expect(result.transactions.startVerificationTxn).toEqual(mockTransactions.startVerificationTxn); | ||
| }); | ||
| it("should verify snapshot if verification is started", async () => { | ||
| mockDeps.transactionHandler = mockTransactionHandler; | ||
| mockClaim.honest = ClaimHonestState.NONE; | ||
| mockClaim.timestampVerification = 1234; | ||
| mockDeps.claim = mockClaim; | ||
| const result = await checkAndClaim(mockDeps); | ||
| expect(result.transactions.verifySnapshotTxn).toEqual(mockTransactions.verifySnapshotTxn); | ||
| }); | ||
| }); | ||
| }); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| import { EventEmitter } from "events"; | ||
| import { ethers } from "ethers"; | ||
| import { JsonRpcProvider } from "@ethersproject/providers"; | ||
| import { getClaim, ClaimHonestState } from "../utils/claim"; | ||
| import { getLastClaimedEpoch } from "../utils/graphQueries"; | ||
| import { ArbToEthTransactionHandler } from "./transactionHandler"; | ||
| import { BotEvents } from "../utils/botEvents"; | ||
| import { ClaimStruct } from "@kleros/vea-contracts/typechain-types/arbitrumToEth/VeaInboxArbToEth"; | ||
| import { ArbToEthDevnetTransactionHandler } from "./transactionHandlerDevnet"; | ||
| import { getTransactionHandler } from "../utils/ethers"; | ||
| import { Network } from "../consts/bridgeRoutes"; | ||
| interface CheckAndClaimParams { | ||
| chainId: number; | ||
| network: Network; | ||
| claim: ClaimStruct | null; | ||
| epochPeriod: number; | ||
| epoch: number; | ||
| veaInbox: any; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Replace 'any' with specific contract types for 'veaInbox' and 'veaOutbox' Using Apply this diff to fix the issue: interface checkAndClaimParams {
epochPeriod: number;
epoch: number;
- veaInbox: any;
+ veaInbox: VeaInboxArbToEth;
veaInboxProvider: JsonRpcProvider;
- veaOutbox: any;
+ veaOutbox: VeaOutboxArbToEth;
veaOutboxProvider: JsonRpcProvider;
transactionHandler: ArbToEthTransactionHandler | null;
emitter: EventEmitter;Also applies to: 13-13
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mani99brar I understand your reasoning. Using 🧠 Learnings used |
||
| veaInboxProvider: JsonRpcProvider; | ||
| veaOutbox: any; | ||
| veaOutboxProvider: JsonRpcProvider; | ||
| transactionHandler: ArbToEthTransactionHandler | null; | ||
| emitter: EventEmitter; | ||
| fetchClaim?: typeof getClaim; | ||
| fetchLatestClaimedEpoch?: typeof getLastClaimedEpoch; | ||
| fetchTransactionHandler?: typeof getTransactionHandler; | ||
| now?: number; | ||
| } | ||
|
|
||
| async function checkAndClaim({ | ||
| chainId, | ||
| network, | ||
| claim, | ||
| epoch, | ||
| epochPeriod, | ||
| veaInbox, | ||
| veaInboxProvider, | ||
| veaOutbox, | ||
| veaOutboxProvider, | ||
| transactionHandler, | ||
| emitter, | ||
| fetchLatestClaimedEpoch = getLastClaimedEpoch, | ||
| fetchTransactionHandler = getTransactionHandler, | ||
| now = Date.now(), | ||
| }: CheckAndClaimParams) { | ||
| let outboxStateRoot = await veaOutbox.stateRoot(); | ||
| const finalizedOutboxBlock = await veaOutboxProvider.getBlock("finalized"); | ||
| const claimAbleEpoch = Math.floor(now / (1000 * epochPeriod)) - 1; | ||
| if (!transactionHandler) { | ||
| const TransactionHandler = fetchTransactionHandler(chainId, network); | ||
| transactionHandler = new TransactionHandler({ | ||
| network, | ||
| epoch, | ||
| veaInbox, | ||
| veaOutbox, | ||
| veaInboxProvider, | ||
| veaOutboxProvider, | ||
| emitter, | ||
| claim, | ||
| }); | ||
| } else { | ||
| transactionHandler.claim = claim; | ||
| } | ||
| var savedSnapshot; | ||
| var claimData; | ||
| var newMessagesToBridge: boolean; | ||
| var lastClaimChallenged: boolean; | ||
|
|
||
| if (network == Network.DEVNET) { | ||
| const devnetTransactionHandler = transactionHandler as ArbToEthDevnetTransactionHandler; | ||
| if (claim == null) { | ||
| [savedSnapshot, claimData] = await Promise.all([ | ||
| veaInbox.snapshots(epoch), | ||
| fetchLatestClaimedEpoch(veaOutbox.target), | ||
| ]); | ||
|
|
||
| newMessagesToBridge = savedSnapshot != outboxStateRoot && savedSnapshot != ethers.ZeroHash; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replace Apply this diff to fix the references: - newMessagesToBridge = savedSnapshot != outboxStateRoot && savedSnapshot != ethers.ZeroHash;
+ newMessagesToBridge = savedSnapshot != outboxStateRoot && savedSnapshot != ethers.constants.HashZero;
- if (claim.challenger != ethers.ZeroAddress) {
+ if (claim.challenger != ethers.constants.AddressZero) {Also applies to: 99-99
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The constants are correct for "ethers v6"
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain@mani99brar You're absolutely correct. In ethers.js v6, the constants were reorganized and 🌐 Web query: 💡 Result: In Ethers.js v6, the constants for zero hash and zero address have been updated from their v5 counterparts. Here are the correct constants: Zero Address Zero Hash Key changes from v5 to v6:
These constants are commonly used for:
Example usage: import { ZeroAddress, ZeroHash } from 'ethers';
console.log(ZeroAddress); // 0x0000...0000
console.log(ZeroHash); // 0x0000...0000Citations:
@mani99brar You're absolutely correct. In ethers.js v6, the constants were reorganized and ✏️ Learnings added
|
||
| if (newMessagesToBridge && savedSnapshot != ethers.ZeroHash) { | ||
| await devnetTransactionHandler.devnetAdvanceState(savedSnapshot); | ||
| return devnetTransactionHandler; | ||
| } | ||
| } | ||
| } else if (claim == null && epoch == claimAbleEpoch) { | ||
| [savedSnapshot, claimData] = await Promise.all([ | ||
| veaInbox.snapshots(epoch), | ||
| fetchLatestClaimedEpoch(veaOutbox.target), | ||
| ]); | ||
| newMessagesToBridge = savedSnapshot != outboxStateRoot && savedSnapshot != ethers.ZeroHash; | ||
| lastClaimChallenged = claimData.challenged && savedSnapshot == outboxStateRoot; | ||
| if ((newMessagesToBridge || lastClaimChallenged) && savedSnapshot != ethers.ZeroHash) { | ||
| await transactionHandler.makeClaim(savedSnapshot); | ||
| return transactionHandler; | ||
| } | ||
| } else if (claim != null) { | ||
| if (claim.honest == ClaimHonestState.CLAIMER) { | ||
| await transactionHandler.withdrawClaimDeposit(); | ||
| return transactionHandler; | ||
| } else if (claim.honest == ClaimHonestState.NONE) { | ||
| if (claim.challenger != ethers.ZeroAddress) { | ||
| emitter.emit(BotEvents.CLAIM_CHALLENGED, epoch); | ||
| return transactionHandler; | ||
| } | ||
| if (claim.timestampVerification == 0) { | ||
| await transactionHandler.startVerification(finalizedOutboxBlock.timestamp); | ||
| } else { | ||
| await transactionHandler.verifySnapshot(finalizedOutboxBlock.timestamp); | ||
| } | ||
| return transactionHandler; | ||
| } | ||
| } else { | ||
| emitter.emit(BotEvents.CLAIM_EPOCH_PASSED, epoch); | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| export { checkAndClaim, CheckAndClaimParams }; | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove duplicate RPC URL configuration.
The Arbitrum RPC URL is defined twice:
RPC_ARB_SEPOLIA=https://sepolia-rollup.arbitrum.io/rpcRPC_ARB=https://sepolia-rollup.arbitrum.io/rpcThis could lead to confusion. Consider removing one of them or clearly documenting the difference if both are needed.
Also applies to: 4-4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will use a single RPC var for both networks on a chain 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mani99brar Great! Using a single RPC variable per chain is a good simplification that will make the configuration more maintainable. This is a change from your previous approach where you had separate variables for devnet and testnet/mainnet usage, but it should make the codebase cleaner and reduce potential confusion. Let me know if you need any help with implementing this change.
✏️ Learnings added
🧠 Learnings used