feat: export GalMulSlice and GalMulSliceXor #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
commented
Apr 25, 2025
|
You can drop 1.21 if you bump CI. |
|
In And if you feel like it https://github.com/klauspost/reedsolomon/blob/master/.github/workflows/go.yml#L127 and here https://github.com/klauspost/reedsolomon/blob/master/.github/workflows/go.yml#L56 (to 1.24.x) |
|
Added in #297 - you should just be able to merge master to make it build. |
arajasek
force-pushed
the
asr/export-mulslice
branch
from
ca5f265 to
d9dc15f
Compare
|
@klauspost Awesome, thank you for the quick review. I've rebased onto latest master, so this should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #293, this PR exports the
galMulSliceandgalMulSliceXorfunctionality. These well-optimized methods are useful in other contexts, including other coding algorithms.