Skip to content

Adding json and salt diagram support #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding json and salt diagram support #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/store/modules/PlantumlEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ const state: any = {
plantuml: 'plantuml',
server: process.env.VUE_APP_SERVER,
cdn: process.env.VUE_APP_CDN,
startuml: ['@startuml', '@startmindmap', '@startditaa', '@startgantt', '@startwbs'],
enduml: ['@enduml', '@endmindmap', '@endditaa', '@endgantt', '@endwbs'],
startuml: ['@startuml', '@startmindmap', '@startditaa', '@startgantt', '@startwbs', '@startjson', 'startsalt'],
Copy link

@HeinrichAD HeinrichAD Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think startsalt also needs a @ in the beginning.
In this case it would be '@startsalt'

Copy link

@HeinrichAD HeinrichAD Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@startyaml, @startmath and @startlatex and and their respective end token are also missing.

References:

As an alternative to manually maintaining all start and end tokens, one might also consider accepting everything with @start and @end.

enduml: ['@enduml', '@endmindmap', '@endditaa', '@endgantt', '@endwbs', '@endjson', '@endsalt'],
defaultText:
'# PlantUML Editor\n\n1. select template\n2. write uml diagram\n\n@startuml\n\nleft to right direction\n\nactor User\n\nUser --> (1. select template)\nUser --> (2. write uml diagram)\n\n@enduml',
text: '',
Expand Down