Skip to content

Rewire support for orientation=all #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuzeyron merged 3 commits into from
Jan 28, 2026
Merged

Rewire support for orientation=all #1999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec744a2
Refactor orientation validation
Novfensec Jan 28, 2026
91f6696
Add support for multiple orientations in Android config
Novfensec Jan 28, 2026
a82a260
Just `all` to be allowed here
Novfensec Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildozer/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def check_configuration_tokens(self):

orientation = self.config.getlist("app", "orientation", ["landscape"])
for o in orientation:
if o not in ("landscape", "portrait", "landscape-reverse", "portrait-reverse"):
if o not in ("landscape", "portrait", "landscape-reverse", "portrait-reverse", "all"):
adderror(f'[app] "{o}" is not a valid value for "orientation"')
if errors:
self.logger.error('{0} error(s) found in the buildozer.spec'.format(
Expand Down
2 changes: 2 additions & 0 deletions buildozer/targets/android.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,6 +1247,8 @@ def build_package(self):
if config.getdefault('app', 'p4a.bootstrap', 'sdl2') != 'service_only':
# add orientation
orientation = config.getlist('app', 'orientation', ['landscape'])
if 'all' in orientation:
orientation = ['landscape', 'portrait', 'landscape-reverse', 'portrait-reverse']
for orient in orientation:
build_cmd += [("--orientation", orient)]

Expand Down
Loading