Adds Typescript 5+ support #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimamula
reviewed
Nov 26, 2023
Owner
kimamula
left a comment
kimamula
left a comment
There was a problem hiding this comment.
Thank you for raising this PR! Can you take a look at my comments?
| "moduleResolution": "node", | ||
| "noEmitOnError": true, | ||
| "suppressImplicitAnyIndexErrors": true, | ||
| "noUncheckedIndexedAccess": false, |
Owner
There was a problem hiding this comment.
I don't remember why I added suppressImplicitAnyIndexErrors in the tsconfig.json files in the examples folder, but it seems ts files compile without this option. Can you just remove the option without adding noUncheckedIndexedAccess? It seems unnecessary.
| strict: true, | ||
| noEmitOnError: true, | ||
| suppressImplicitAnyIndexErrors: true, | ||
| noUncheckedIndexedAccess: false, |
| suppressImplicitAnyIndexErrors: true, | ||
| noUncheckedIndexedAccess: false, | ||
| esModuleInterop: true, | ||
| moduleResolution: getDefaultModuleResolution(), |
Owner
There was a problem hiding this comment.
Is this needed? I confirmed npm test succeeds without this.
Comment on lines
+4
to
+36
| type ArrayFactory = ( | ||
| elements?: readonly ts.Expression[] | undefined, | ||
| multiLine?: boolean | undefined | ||
| ) => ts.ArrayLiteralExpression; | ||
|
|
||
| const createArrayExpression = ((): ArrayFactory => { | ||
| if (ts.factory) { | ||
| return ts.factory.createArrayLiteralExpression; | ||
| } | ||
|
|
||
| if ("createArrayLiteral" in ts) { | ||
| return ts.createArrayLiteral as ArrayFactory; | ||
| } | ||
|
|
||
| throw new Error("Cannot choose array literal factory"); | ||
| })(); | ||
|
|
||
| type StringFactory = ( | ||
| text: string, | ||
| isSingleQuote?: boolean | undefined | ||
| ) => ts.StringLiteral; | ||
|
|
||
| const createStringLiteral = ((): StringFactory => { | ||
| if (ts.factory) { | ||
| return ts.factory.createStringLiteral; | ||
| } | ||
|
|
||
| if ("createLiteral" in ts) { | ||
| return ts.createLiteral as StringFactory; | ||
| } | ||
|
|
||
| throw new Error("Cannot choose string literal factory"); | ||
| })(); |
Owner
There was a problem hiding this comment.
The following should be much easier:
Suggested change
| type ArrayFactory = ( | |
| elements?: readonly ts.Expression[] | undefined, | |
| multiLine?: boolean | undefined | |
| ) => ts.ArrayLiteralExpression; | |
| const createArrayExpression = ((): ArrayFactory => { | |
| if (ts.factory) { | |
| return ts.factory.createArrayLiteralExpression; | |
| } | |
| if ("createArrayLiteral" in ts) { | |
| return ts.createArrayLiteral as ArrayFactory; | |
| } | |
| throw new Error("Cannot choose array literal factory"); | |
| })(); | |
| type StringFactory = ( | |
| text: string, | |
| isSingleQuote?: boolean | undefined | |
| ) => ts.StringLiteral; | |
| const createStringLiteral = ((): StringFactory => { | |
| if (ts.factory) { | |
| return ts.factory.createStringLiteral; | |
| } | |
| if ("createLiteral" in ts) { | |
| return ts.createLiteral as StringFactory; | |
| } | |
| throw new Error("Cannot choose string literal factory"); | |
| })(); | |
| declare module "typescript" { | |
| const createArrayLiteral: typeof ts.factory.createArrayLiteralExpression; | |
| const createLiteral: typeof ts.factory.createStringLiteral; | |
| } | |
| const createArrayExpression = ts.factory ? ts.factory.createArrayLiteralExpression : ts.createArrayLiteral; | |
| const createStringLiteral = ts.factory ? ts.factory.createStringLiteral : ts.createLiteral; |
What do you think?
| "noFallthroughCasesInSwitch": true, | ||
| "esModuleInterop": true | ||
| "esModuleInterop": true, | ||
| "noUncheckedIndexedAccess": false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many deprecated parts of tsAPI were removed from the ts5 release, so updating to ts5 breaks projects.
Added support to the new API with the help of dynamic checks of what API version is used right now.