-
Notifications
You must be signed in to change notification settings - Fork 108
Add end frame setting support #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Maybe instead of averaging start/end frame clipvision embeddings and using the same result for all segments (latent_paddings) it would be better to have as many embeddings as there are latent_paddings and interpolate them? |
|
@IntendedConsequence Yes, it's a great idea (and such interpolation is actually a unique advantage of next frame prediction models over full-context diffusion models). One note is that the previous frames could need the last frame's context to "know" that happens there, if we want to have smooth transitions aware of both ends, and averaging the embeddings can be a good compromise. I can add a binary switch for this first-last frame interpolation mode (0->1) and averaging (0.5). @Qi-0072 I don't see your image file, personally |
|
@kabachuha did you see any difference with interpolation if I may ask? |
|
Yes, the transition of the example above became a bit smoother (in particular, regarding the end frame rabbit's behavior) and the weighted average with different parameter control how fast the background transforms and also affects the rabbit :) Didn't test it with more complex environments yet. I'm not at home right now, so I suggest to try it yourself with various settings. |
|
FramePackSampler.process() got an unexpected keyword argument 'image_end_embeds' |
|
@berryyan Are you on my branch or only using the example workflow I provided? |
是的 我再尝试一次切换分支 |
|
(ComfyUI) E:\AI\ComfyUI\ComfyUI\custom_nodes\ComfyUI-FramePackWrapper>gh pr checkout 5
还是失败...而且报错变了 我再查找一下原因,我是5090的显卡,可能有些环境和插件的确和别人不太一样。 |
|
@kijai Are you ready to review this PR? |
|
@kabachuha @kijai I've encountered a bug with division by zero I think for low duration (1 second) and interpolation type is set to linear. Can't try repro right now but saved the stack trace: |
|
@jeerychao stop hijacking threads, this is not a support forum. Please delete your messages. |

This pull request adds setting the last generation frame by substituting it and averaging the CLIP embeddings
Taken from lllyasviel/FramePack#167
Example of this workflow working:
https://github.com/user-attachments/assets/9fbf61e9-5a68-456c-9753-23d4dd8041bb
Workflow:
example-multi.json